Re: xl and GFX passthrough

[Ian Campbell <Ian.Campbell@eu.citrix.com>]

On Thu, 2011-01-13 at 11:17 +0000, Sergey Tovpeko wrote:
> >
> > I just noticed that this appears to have been fixed by Daniel De Graf
> > just a few days ago, see 22711:4f6fee3a456e, which may only be in the
> > staging tree at http://xenbits.xen.org/staging/xen-unstable.hg since we
> > are waiting for a test pass.
> >
> >   
> 
> Ian, Daniel
>  
>   my patch is almost like Daniel's one.  Thank you for pointing to it.
> 
> And there's one absent thing in Daniel's commit (4f6fee3a456e). To 
> complete the gfx passthrough issue for xl we should pass this option to 
> qemu-dm, like this :
> 
> +        if (info->gfx_passthru) {
> +            flexarray_set(dm_args, num++, "-gfx_passthru");
> +            flexarray_set(dm_args, num++, libxl__sprintf(gc, "%d", 
> info->gfx_passthru));
> +        }
> 
> I suppose, without it 'qemu-dm' won't  know about gfx_passthru mode and 
> won't load passthru'ed vga bios.
> 
> Daniel might plan to add this code or added it already?

Daniel's patch at <4D262B2A.30907@tycho.nsa.gov> includes this bit but
it appears to be missing from the commit in 22711:4f6fee3a456e.

IanJ: Any idea what's going on? Perhaps a missed .rej due to the move of
the dm stuff to libxl_dm.c between post and application?

Ian.