From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E1BBC433EF for ; Sun, 6 Feb 2022 18:23:18 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9154D83B99; Sun, 6 Feb 2022 19:23:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="VVUe0FTN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8238983BB5; Sun, 6 Feb 2022 19:23:14 +0100 (CET) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F20AB83B99 for ; Sun, 6 Feb 2022 19:23:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: phobos.denx.de; spf=none smtp.helo=mail-wr1-x436.google.com Received: by mail-wr1-x436.google.com with SMTP id s18so21104649wrv.7 for ; Sun, 06 Feb 2022 10:23:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cm9WiwEPUwCu7AvpsJa1RvIQl8WRz9fpf++v2RioIiU=; b=VVUe0FTNN3nziUmZUxg9P82b0rUkvcOtWCWnfL1H/nwsJ16VjHdGCn8O7MEFJwYk1+ Me0b3OGGiZbIwgtoVyCbmTJJmzMAyhMBBu/8MltgC4meHnrv4pytSBhRDYeozJgng1bq LcNnYbVByN/DRiAfq5CZLzZoO3dvC2pzz1MeM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cm9WiwEPUwCu7AvpsJa1RvIQl8WRz9fpf++v2RioIiU=; b=sGjH3WkuP+Th3lzwiG0SWHk7wgTe5IL2pd1b/7fa/IYNvNPKssP5j0LrnUSJoN/Afw IXR4xKTUm5tHoAmdN2KX02km74wBXQM+E9PdxHvBgmdLJe19ivKGn5bUk8/4QUJpMUmo +MClZc2U8K+1FdX9zhIOzEgkXPqNMa0Iebt2sJupj9vn3BT5taH0M1q0vMRu9y5Ssada YaENLAObXv44QvFYuaONaGf49NyTPxFikRY5XpMb0U6Xav7TVG4NZmScs/cCI1Y9g5EP syNumCuhqyk0NahpxxoJisOAx6enNYqaZAOGssCdU4uDi4RqBRVbfjrV6Cuk4aEAman0 9Kqg== X-Gm-Message-State: AOAM5337HBS5Fy7OTS2/NBUdBqoa0N0Y7Ov5pVRZYKClzAESQvUfwPiu kbiVxQB0d3ReNIZKWqnFiu8EXw== X-Google-Smtp-Source: ABdhPJxDlfvWL3ES4ffVVaCFCd5loCmq2l3qPs5tiayeBqUSpNrSFBXbUY1+ft4/fH41ZZ2Va38cCg== X-Received: by 2002:a5d:4141:: with SMTP id c1mr1540439wrq.271.1644171791646; Sun, 06 Feb 2022 10:23:11 -0800 (PST) Received: from pwmachine.localnet ([2a01:cb14:983:1f00:e5b3:218b:cb92:2549]) by smtp.gmail.com with ESMTPSA id e9sm1325602wme.12.2022.02.06.10.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Feb 2022 10:23:11 -0800 (PST) From: Francis Laniel To: Simon Glass Cc: U-Boot Mailing List , Marek Behun , Michael Nazzareno Trimarchi , Wolfgang Denk , Harald Seiler Subject: Re: [RFC PATCH v1 16/21] test: hush: Fix variable expansion tests for hush 2021. Date: Sun, 06 Feb 2022 19:23:10 +0100 Message-ID: <12953040.uLZWGnKmhe@pwmachine> In-Reply-To: References: <20211231161327.24918-1-francis.laniel@amarulasolutions.com> <20211231161327.24918-17-francis.laniel@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Le mercredi 12 janvier 2022, 21:03:37 CET Simon Glass a =E9crit : > Hi Francis, >=20 > On Fri, 31 Dec 2021 at 09:14, Francis Laniel >=20 > wrote: > > This commit modifies the expected result for hush 2021. > > Indeed, there were bugs in actual U-Boot hush which were fixed in upstr= eam > > Busybox. > > As hush 2021 is based on upstream Busybox, these bugs no longer exist. > >=20 > > Signed-off-by: Francis Laniel > > --- > >=20 > > test/hush/dollar.c | 51 ++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 51 insertions(+) >=20 > Reviewed-by: Simon Glass >=20 > Can you avoid the preprocessor macros? >=20 > Also, for testing we really want to be able to run both sets of tests > in sandbox, so the parser needs to be run-time selectable. To be sure, you would like to have a global variable named, for example,=20 parser which value could be: * parser =3D "old", for old hush parser * parser =3D "2021", for "new" hush parser Is my understanding correct? > Regards, > Simon