From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH v2 0/4] Tegra: Harmony: Add internal speaker support Date: Thu, 20 Jan 2011 10:04:38 +0000 Message-ID: <1295517879.3277.1.camel@odin> References: <1295393859-3396-1-git-send-email-swarren@wwwdotorg.org> <1295470205-26501-1-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wy0-f179.google.com (mail-wy0-f179.google.com [74.125.82.179]) by alsa0.perex.cz (Postfix) with ESMTP id C659B103A56 for ; Thu, 20 Jan 2011 11:04:42 +0100 (CET) Received: by wyi11 with SMTP id 11so404008wyi.38 for ; Thu, 20 Jan 2011 02:04:42 -0800 (PST) In-Reply-To: <1295470205-26501-1-git-send-email-swarren@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Stephen Warren Cc: linux-tegra@vger.kernel.org, alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com List-Id: alsa-devel@alsa-project.org On Wed, 2011-01-19 at 13:50 -0700, Stephen Warren wrote: > Harmony has headers on the board for an internal speaker and internal mic. > This patch series adds various infra-structure, and enables usage of the > internal speaker. > > The patch series includes both changes to code within the ASoC > subsystem and Tegra subsystem, the latter provided only for context when > reading the ASoC changes. Would you prefer I separated these so that the > ASoC maintainers can grab a whole series and apply it, rather than just > a subset of the patches? > > While patch 2 is physically located in the Tegra subsystem, I'd > consider it part of the ASoC driver. Can such a change be checked into > the ASoC tree? This new header file will be required to build to ASoC driver > once the following patches are in. I was considering placing this in > include/sound, following the example of various codecs, but it doesn't seem > a good idea to pollute that directory with platform-specific files. The > current location for the file follows the example of s3c24xx/simtec. Perhaps > it should be in sound/soc/tegra? > > Stephen Warren (4): > ASoC: WM8903: Expose GPIOs through gpiolib > ARM: tegra: Add Harmony sound platform data type > ARM: tegra: Platform data fixes for ASoC driver updates > ASoC: tegra: Harmony: Support the internal speaker > > arch/arm/mach-tegra/board-harmony.c | 31 ++++++ > arch/arm/mach-tegra/gpio-names.h | 2 + > arch/arm/mach-tegra/include/mach/harmony_audio.h | 19 ++++ > include/sound/wm8903.h | 7 +- > sound/soc/codecs/wm8903.c | 117 +++++++++++++++++++++- > sound/soc/tegra/harmony.c | 89 ++++++++++++++-- > 6 files changed, 251 insertions(+), 14 deletions(-) > create mode 100644 arch/arm/mach-tegra/include/mach/harmony_audio.h > All Acked-by: Liam Girdwood -- Freelance Developer, SlimLogic Ltd ASoC and Voltage Regulator Maintainer. http://www.slimlogic.co.uk