All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: oFono exits on new voicecall with disconnected system bus
Date: Fri, 21 Jan 2011 13:10:51 +0100	[thread overview]
Message-ID: <1295611851.3873.306.camel@aeonflux> (raw)
In-Reply-To: <AANLkTinuBhsEv3yduBfU6S58F-q9pddVVQrizn4KEKKA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

Hi Nicola,

> >> It seems that in src/voicecall.c/append_voicecall_properties "name"
> >> points to garbage as commenting the line:
> >> ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
> >> fixes the problem.
> >
> > can you print the content of name and call->name fields as part of a
> > debug statement. I like to see what is in there.
> >
> > At least the pointer should be valid since it pointers to call->name
> > array. Maybe the content is just not UTF-8 string.
> 
> 
>         ofono_dbus_dict_append(dict, "LineIdentification",
>                                 DBUS_TYPE_STRING, &callerid);
> 
>         DBG("name %s call->name %s", name, call->name);
>         ofono_dbus_dict_append(dict, "Name", DBUS_TYPE_STRING, &name);
> 
> 
> ofonod[5771]: src/voicecall.c:ofono_voicecall_notify() Did not find a
> call with id: 1
> ofonod[5771]: src/voicecall.c:append_voicecall_properties() name ��+@
> call->name ��+@
> ofonod[5771]: System bus has disconnected!

I think that I found the problem. Pushed a patch for it. Please re-test
if this helps. The Calypso driver was using stack memory for the call
object.

Regards

Marcel



  parent reply	other threads:[~2011-01-21 12:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-20 14:51 oFono exits on new voicecall with disconnected system bus Nicola Mfb
2011-01-20 14:55 ` Marcel Holtmann
2011-01-21  9:04   ` Nicola Mfb
2011-01-21 10:29     ` Marcel Holtmann
2011-01-21 11:33       ` Nicola Mfb
2011-01-21 12:03         ` Marcel Holtmann
2011-01-21 12:10         ` Marcel Holtmann [this message]
2011-01-21 14:04           ` Nicola Mfb

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295611851.3873.306.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.