From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Walker Subject: Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check Date: Mon, 24 Jan 2011 13:35:28 -0800 Message-ID: <1295904928.29639.58.camel@c-dwalke-linux.qualcomm.com> References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1295468747-22796-1-git-send-email-davidb@codeaurora.org> <1295468747-22796-8-git-send-email-davidb@codeaurora.org> <1295901976.29639.53.camel@c-dwalke-linux.qualcomm.com> <8yak4hukn00.fsf@huya.qualcomm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:26191 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751301Ab1AXVf4 (ORCPT ); Mon, 24 Jan 2011 16:35:56 -0500 In-Reply-To: <8yak4hukn00.fsf@huya.qualcomm.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: David Brown Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Mon, 2011-01-24 at 13:30 -0800, David Brown wrote: > On Mon, Jan 24 2011, Daniel Walker wrote: > > > On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: > >> diff --git a/arch/arm/mach-msm/include/mach/cpu.h > >> b/arch/arm/mach-msm/include/mach/cpu.h > >> index e1ba9db..a9481b0 100644 > >> --- a/arch/arm/mach-msm/include/mach/cpu.h > >> +++ b/arch/arm/mach-msm/include/mach/cpu.h > >> @@ -24,6 +24,7 @@ > >> #define cpu_is_msm7x30() 0 > >> #define cpu_is_qsd8x50() 0 > >> #define cpu_is_msm8x60() 0 > >> +#define cpu_is_msm8960() 0 > > > > The naming is just perverted even more here.. > > What do you want me to call it? > > #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() I want you to call it msm8x60 .. > It's the name of the chip. We've already been through this. The names > are unfortunate, but it is what the devices are called. I think you can re-org things to mask all this.. I've been suggesting is that we look into that .. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. From mboxrd@z Thu Jan 1 00:00:00 1970 From: dwalker@codeaurora.org (Daniel Walker) Date: Mon, 24 Jan 2011 13:35:28 -0800 Subject: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check In-Reply-To: <8yak4hukn00.fsf@huya.qualcomm.com> References: <1292384961-8851-1-git-send-email-stepanm@codeaurora.org> <1295468747-22796-1-git-send-email-davidb@codeaurora.org> <1295468747-22796-8-git-send-email-davidb@codeaurora.org> <1295901976.29639.53.camel@c-dwalke-linux.qualcomm.com> <8yak4hukn00.fsf@huya.qualcomm.com> Message-ID: <1295904928.29639.58.camel@c-dwalke-linux.qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, 2011-01-24 at 13:30 -0800, David Brown wrote: > On Mon, Jan 24 2011, Daniel Walker wrote: > > > On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote: > >> diff --git a/arch/arm/mach-msm/include/mach/cpu.h > >> b/arch/arm/mach-msm/include/mach/cpu.h > >> index e1ba9db..a9481b0 100644 > >> --- a/arch/arm/mach-msm/include/mach/cpu.h > >> +++ b/arch/arm/mach-msm/include/mach/cpu.h > >> @@ -24,6 +24,7 @@ > >> #define cpu_is_msm7x30() 0 > >> #define cpu_is_qsd8x50() 0 > >> #define cpu_is_msm8x60() 0 > >> +#define cpu_is_msm8960() 0 > > > > The naming is just perverted even more here.. > > What do you want me to call it? > > #define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1() I want you to call it msm8x60 .. > It's the name of the chip. We've already been through this. The names > are unfortunate, but it is what the devices are called. I think you can re-org things to mask all this.. I've been suggesting is that we look into that .. Daniel -- Sent by a consultant of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.