From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Jeremy Fitzhardinge <firstname.lastname@example.org>
Cc: "email@example.com" <firstname.lastname@example.org>,
Subject: Re: [PATCH] xen: netfront: Drop GSO SKBs which do not have csum_blank.
Date: Tue, 25 Jan 2011 17:09:36 +0000 [thread overview]
Message-ID: <email@example.com> (raw)
On Mon, 2011-01-24 at 17:55 +0000, Jeremy Fitzhardinge wrote:
> No, I didn't mean to drop the skb_is_gso() test. But still, the if()s
> can be folded to share the same body.
My original opinion was that sharing that bit of body at the expense of
an increasingly hard to decipher if conditional was not a good trade
However thinking about it again I think the test logic would be better
of factored out into a validate_incoming_skb() type function anyway.
Short (2 patch) replacement series follows.
next prev parent reply other threads:[~2011-01-25 17:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 13:23 [PATCH] xen: netfront: Drop GSO SKBs which do not have csum_blank Ian Campbell
2011-01-11 11:46 ` Ian Campbell
2011-01-22 0:58 ` Jeremy Fitzhardinge
2011-01-22 9:43 ` Ian Campbell
2011-01-24 17:55 ` Jeremy Fitzhardinge
2011-01-25 17:09 ` Ian Campbell [this message]
2011-01-25 17:09 ` [PATCH 1/2] xen: netfront: refactor code for checking validity of incoming skbs Ian Campbell
2011-01-25 17:09 ` Ian Campbell
2011-01-25 17:10 ` [PATCH 2/2] xen: netfront: Drop GSO SKBs which do not have csum_blank Ian Campbell
2011-01-25 17:10 ` Ian Campbell
2011-01-26 3:44 ` David Miller
2011-01-26 11:56 ` Ian Campbell
2011-01-27 14:14 ` [PATCH] xen: netfront: handle incoming GSO SKBs which are not CHECKSUM_PARTIAL Ian Campbell
2011-01-27 14:14 ` Ian Campbell
2011-01-27 22:23 ` David Miller
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.