From: "Sosnowski, Maciej" <maciej.sosnowski@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Haavard Skinnemoen <hskinnemoen@atmel.com>
Subject: RE: [PATCH] dmaengine: Add Kconfig of DMA data align for DMA Test driver
Date: Wed, 18 Mar 2009 12:09:52 +0000 [thread overview]
Message-ID: <129600E5E5FB004392DDC3FB599660D786B0DFC5@irsmsx504.ger.corp.intel.com> (raw)
In-Reply-To: <e9c3a7c20903161502x4738db4drc9e3abae782e4364@mail.gmail.com>
Dan Williams wrote:
> On Wed, Mar 11, 2009 at 11:30 PM, Nobuhiro Iwamatsu
> <iwamatsu.nobuhiro@renesas.com> wrote:
>> Test drivers of DMA engine usually perform DMA transfer by 1 byte
>> unit. This can set transfer size of DMA and aligns data for tests.
>>
>> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
>> Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
>> Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>
>> Cc: Dan Williams <dan.j.williams@intel.com>
>> ---
>
> This should just be a module parameter, and it needs error handling
> for the alignment > transfer length case.
>
> Thanks,
> Dan
I agree with Dan. Align size should be rather module parameter.
Regards,
Maciej
prev parent reply other threads:[~2009-03-18 12:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 6:30 [PATCH] dmaengine: Add Kconfig of DMA data align for DMA Test driver Nobuhiro Iwamatsu
2009-03-16 22:02 ` Dan Williams
2009-03-18 12:09 ` Sosnowski, Maciej [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=129600E5E5FB004392DDC3FB599660D786B0DFC5@irsmsx504.ger.corp.intel.com \
--to=maciej.sosnowski@intel.com \
--cc=dan.j.williams@intel.com \
--cc=hskinnemoen@atmel.com \
--cc=iwamatsu.nobuhiro@renesas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.