* [PATCH V2] firmware_classs: change val uevent's type to bool
@ 2011-01-26 10:33 Bob Liu
2011-01-26 16:59 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Bob Liu @ 2011-01-26 10:33 UTC (permalink / raw)
To: linux-kernel
Cc: chrisw, tomas.winkler, johannes.berg, dmitry.torokhov, gregkh, Bob Liu
Some place in firmware_class.c using "int uevent" define, but others use "bool
uevent".
This patch replace all int uevent define to bool.
Changes since V1:
johannes: remove no-op
Signed-off-by: Bob Liu <lliubbo@gmail.com>
---
drivers/base/firmware_class.c | 7 +++----
include/linux/firmware.h | 4 ++--
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 40af43e..8c798ef 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -593,8 +593,7 @@ int
request_firmware(const struct firmware **firmware_p, const char *name,
struct device *device)
{
- int uevent = 1;
- return _request_firmware(firmware_p, name, device, uevent, false);
+ return _request_firmware(firmware_p, name, device, true, false);
}
/**
@@ -618,7 +617,7 @@ struct firmware_work {
struct device *device;
void *context;
void (*cont)(const struct firmware *fw, void *context);
- int uevent;
+ bool uevent;
};
static int request_firmware_work_func(void *arg)
@@ -661,7 +660,7 @@ static int request_firmware_work_func(void *arg)
**/
int
request_firmware_nowait(
- struct module *module, int uevent,
+ struct module *module, bool uevent,
const char *name, struct device *device, gfp_t gfp, void *context,
void (*cont)(const struct firmware *fw, void *context))
{
diff --git a/include/linux/firmware.h b/include/linux/firmware.h
index 53d1e6c..21b3e75 100644
--- a/include/linux/firmware.h
+++ b/include/linux/firmware.h
@@ -39,7 +39,7 @@ struct builtin_fw {
int request_firmware(const struct firmware **fw, const char *name,
struct device *device);
int request_firmware_nowait(
- struct module *module, int uevent,
+ struct module *module, bool uevent,
const char *name, struct device *device, gfp_t gfp, void *context,
void (*cont)(const struct firmware *fw, void *context));
@@ -52,7 +52,7 @@ static inline int request_firmware(const struct firmware **fw,
return -EINVAL;
}
static inline int request_firmware_nowait(
- struct module *module, int uevent,
+ struct module *module, bool uevent,
const char *name, struct device *device, gfp_t gfp, void *context,
void (*cont)(const struct firmware *fw, void *context))
{
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2] firmware_classs: change val uevent's type to bool
2011-01-26 10:33 [PATCH V2] firmware_classs: change val uevent's type to bool Bob Liu
@ 2011-01-26 16:59 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2011-01-26 16:59 UTC (permalink / raw)
To: Bob Liu; +Cc: linux-kernel, chrisw, tomas.winkler, johannes.berg, gregkh
On Wed, Jan 26, 2011 at 06:33:32PM +0800, Bob Liu wrote:
> Some place in firmware_class.c using "int uevent" define, but others use "bool
> uevent".
> This patch replace all int uevent define to bool.
>
> Changes since V1:
> johannes: remove no-op
Actually what you removed is the only non-noop from your previous patch.
And changelog like this should go below "---" separator so import
scripts ignore it.
Anyways,
Acked-by: Dmitry Torokhov <dtor@mail.ru>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-26 17:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-26 10:33 [PATCH V2] firmware_classs: change val uevent's type to bool Bob Liu
2011-01-26 16:59 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.