All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: ofono@ofono.org
Subject: Re: [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation
Date: Wed, 26 Jan 2011 12:48:25 +0100	[thread overview]
Message-ID: <1296042505.1520.130.camel@aeonflux> (raw)
In-Reply-To: <AANLkTinrU2Mxym1=HrEqGmrSP6Lqn98Cs8aQ=taeRfQi@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

Hi Aki,

> > Just on a different thought here. The NETWORK_REGISTRATION_MODE_* is
> > local to src/network.c. We could just add the AUTO_ONLY mode there.
> >
> > The only downside I is see the already nasty init_registration_status
> > check, but that might be acceptable compared to crippling the string
> > conversion function.
> >
> > However at least the check would be clearly to just checking mode and
> > not mode + forced_mode.
> 
> I thought about this, but then we'd need more logic to when the user
> calls NetworkRegistration.Register() for automatic mode. That
> obviously can't change the mode. But perhaps this is now more
> manageable, since we got rid of Deregister(), which means there is
> just this one case to worry about.

can you have a stab at this and check how a patch would look like if we
just add another mode. If I am not mistaken we only have the extra code
in the init_registration_status. I could be wrong here since I have not
looked through that code in a long time.

Denis, any comments?

Regards

Marcel



  reply	other threads:[~2011-01-26 11:48 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26  9:19 [PATCH 0/4] Add support for CPHS customer service profile Aki Niemi
2011-01-26  9:19 ` [PATCH 1/4] simutil: Add EFcsp file and service group IDs Aki Niemi
2011-01-26  9:39   ` Marcel Holtmann
2011-01-26  9:19 ` [PATCH 2/4] netreg: Add CPHS CSP PLMN mode implementation Aki Niemi
2011-01-26  9:47   ` Marcel Holtmann
2011-01-26 10:32     ` Aki Niemi
2011-01-26 11:12       ` Marcel Holtmann
2011-01-26 11:45         ` Aki Niemi
2011-01-26 11:48           ` Marcel Holtmann [this message]
2011-01-26 11:51             ` Aki Niemi
2011-01-26  9:19 ` [PATCH 3/4] doc: Add documentation for 'auto-only' mode Aki Niemi
2011-01-26  9:41   ` Marcel Holtmann
2011-01-26  9:19 ` [PATCH 4/4] TODO: Remove completed CPHS CSP task Aki Niemi
2011-01-26  9:50 ` [PATCH 0/4] Add support for CPHS customer service profile Marcel Holtmann
2011-01-26 10:17   ` Aki Niemi
2011-01-26 10:28     ` Marcel Holtmann
2011-01-26 10:34       ` Aki Niemi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296042505.1520.130.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=ofono@ofono.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.