From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754095Ab1AZSaT (ORCPT ); Wed, 26 Jan 2011 13:30:19 -0500 Received: from [123.122.106.155] ([123.122.106.155]:38817 "EHLO enigma.site" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753669Ab1AZS3H (ORCPT ); Wed, 26 Jan 2011 13:29:07 -0500 From: Coly Li To: linux-kernel@vger.kernel.org Cc: Coly Li , Andrew Morton , Greg KH Subject: [PATCH 0/6] use BUG_ON correctly Date: Thu, 27 Jan 2011 02:54:49 +0800 Message-Id: <1296068095-16988-1-git-send-email-bosong.ly@taobao.com> X-Mailer: git-send-email 1.7.3.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org BUG_ON() already uses unlikely() inside its definition if possible, therefore code should not use BUG_ON() with explicit unlikely() like BUG_ON(unlikely(...)), an explicit unlikely() doesn't make things better. This patch set fixes all incorrect usage of BUG_ON() as the above line mentioned. Signed-off-by: Coly Li Cc: Andrew Morton Cc: Greg KH --- drivers/dma/iop-adma.c | 6 +++--- drivers/dma/mv_xor.c | 6 +++--- drivers/dma/ppc4xx/adma.c | 8 ++++---- drivers/scsi/scsi_lib.c | 4 ++-- drivers/staging/brcm80211/brcmfmac/wl_cfg80211.c | 14 +++++++------- mm/nommu.c | 10 +++++----- 6 files changed, 24 insertions(+), 24 deletions(-)