All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Don Skidmore <donald.c.skidmore@intel.com>,
	bphilips@novell.com, netdev@vger.kernel.org,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	gospo@redhat.com, stable@kernel.org
Subject: [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting.
Date: Thu, 27 Jan 2011 22:18:51 -0800	[thread overview]
Message-ID: <1296195535-2990-4-git-send-email-jeffrey.t.kirsher__3689.82048607922$1296200671$gmane$org@intel.com> (raw)
In-Reply-To: <1296195535-2990-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Don Skidmore <donald.c.skidmore@intel.com>

We have found a hardware erratum on 82599 hardware that can lead to
unpredictable behavior when Header Splitting mode is enabled.  So
we are no longer enabling this feature on affected hardware.

Please see the 82599 Specification Update for more information.

CC: stable@kernel.org
Signed-off-by: Don Skidmore <donald.c.skidmore@intel.com>
Tested-by: Stephen Ko <stephen.s.ko@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ixgbe/ixgbe_main.c |   11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 44a1cf0..1495b74 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -3176,9 +3176,16 @@ static void ixgbe_set_rx_buffer_len(struct ixgbe_adapter *adapter)
 	u32 mhadd, hlreg0;
 
 	/* Decide whether to use packet split mode or not */
+	/* On by default */
+	 adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+
 	/* Do not use packet split if we're in SR-IOV Mode */
-	if (!adapter->num_vfs)
-		adapter->flags |= IXGBE_FLAG_RX_PS_ENABLED;
+	if (adapter->num_vfs)
+		adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
+
+	/* Disable packet split due to 82599 erratum #45 */
+	if (hw->mac.type == ixgbe_mac_82599EB)
+		adapter->flags &= ~IXGBE_FLAG_RX_PS_ENABLED;
 
 	/* Set the RX buffer length according to the mode */
 	if (adapter->flags & IXGBE_FLAG_RX_PS_ENABLED) {
-- 
1.7.3.5

  parent reply	other threads:[~2011-01-28  6:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-28  6:18 [net-2.6 0/7][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2011-01-28  6:18 ` [net-2.6 1/7] e1000: add support for Marvell Alaska M88E1118R PHY Jeff Kirsher
2011-01-28  6:18 ` [net-2.6 2/7] ixgbe: fix variable set but not used warnings by gcc 4.6 Jeff Kirsher
2011-01-28  6:18 ` Jeff Kirsher [this message]
2011-01-28  6:18 ` [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher
2011-01-28  6:33   ` David Miller
2011-01-28  6:58     ` Jeff Kirsher
2011-01-28  6:18 ` [net-2.6 4/7] ixgbe: limit VF access to network traffic Jeff Kirsher
2011-01-28  6:18 ` [net-2.6 5/7] ixgbe: DDP last buffer size work around Jeff Kirsher
2011-01-28  6:34   ` David Miller
2011-01-28  6:18 ` [net-2.6 6/7] ixgbe: cleanup variable initialization Jeff Kirsher
2011-01-28  6:18 ` [net-2.6 7/7] ixgbe: update version string Jeff Kirsher
     [not found] <1296195143-2870-1-git-send-email-jeffrey.t.kirsher@intel.com>
2011-01-28  6:12 ` [net-2.6 3/7] ixgbe: fix for 82599 erratum on Header Splitting Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='1296195535-2990-4-git-send-email-jeffrey.t.kirsher__3689.82048607922$1296200671$gmane$org@intel.com' \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=bphilips@novell.com \
    --cc=donald.c.skidmore@intel.com \
    --cc=gospo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.