All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislav Brabec <sbrabec@suse.cz>
To: Yin Kangkai <kangkai.yin@linux.intel.com>
Cc: linux-serial <linux-serial@vger.kernel.org>,
	Greg KH <greg@kroah.com>, Deepak Saxena <dsaxena@laptop.org>,
	Jason Wang <jason77.wang@gmail.com>,
	Daniel Drake <dsd@laptop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] serial-core: reset the console speed on resume
Date: Sun, 30 Jan 2011 01:20:58 +0100	[thread overview]
Message-ID: <1296346859.5397.29.camel@utx.lan> (raw)
In-Reply-To: <20110125104302.GM3315@kai-debian>

Yin Kangkai wrote on Tue 25 Jan 2011 at 18:43 +0800:

> On some platforms, we need to restore the console speed on resume even
> it was not suspended (no_console_suspend), and on others we don't have
> to do that.
> 
> So don't care about the "console_suspend_enabled" and unconditionally
> reset the console speed if it is a console.

Well, there is currently another breakage on Zaurus. But it improves the
situation.
(Note: Your patch has bad file path. I'll agree with such change after
this fix.)

Test report on Zaurus
(serial hardware itself is in undefined state after resume):

                                       before  after
login:                                   OK     OK
console:                               broken broken
console + login:                         OK     OK
console + no_console_suspend:          broken broken
login + no_console_suspend:              OK     OK
console + login + no_console_suspend:  broken   OK

-- 
Best Regards / S pozdravem,

Stanislav Brabec
software developer
---------------------------------------------------------------------
SUSE LINUX, s. r. o.                          e-mail: sbrabec@suse.cz
Lihovarská 1060/12                            tel: +49 911 7405384547
190 00 Praha 9                                  fax: +420 284 028 951
Czech Republic                                    http://www.suse.cz/


  reply	other threads:[~2011-01-30  0:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-25 10:43 [PATCH RFC] serial-core: reset the console speed on resume Yin Kangkai
2011-01-30  0:20 ` Stanislav Brabec [this message]
2011-01-30  2:25   ` Yin Kangkai
2011-01-30  3:15 ` [PATCH Resend] " Yin Kangkai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296346859.5397.29.camel@utx.lan \
    --to=sbrabec@suse.cz \
    --cc=dsaxena@laptop.org \
    --cc=dsd@laptop.org \
    --cc=greg@kroah.com \
    --cc=jason77.wang@gmail.com \
    --cc=kangkai.yin@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.