All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, "Linus Lüssing" <linus.luessing@web.de>,
	"Sven Eckelmann" <sven@narfation.org>
Subject: [PATCH 1/4] batman-adv: Fix kernel panic when fetching vis data on a vis server
Date: Sun, 30 Jan 2011 10:38:49 +0100	[thread overview]
Message-ID: <1296380332-4269-1-git-send-email-sven@narfation.org> (raw)
In-Reply-To: <201101301036.57928.sven@narfation.org>

From: Linus Lüssing <linus.luessing@web.de>

The hash_iterate removal introduced a bug leading to a kernel panic when
fetching the vis data on a vis server. That commit forgot to rename one
variable name, which this commit fixes now.

Reported-by: Russell Senior <russell@personaltelco.net>
Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
---
 net/batman-adv/vis.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/batman-adv/vis.c b/net/batman-adv/vis.c
index cd4c423..f69a374 100644
--- a/net/batman-adv/vis.c
+++ b/net/batman-adv/vis.c
@@ -268,10 +268,10 @@ int vis_seq_print_text(struct seq_file *seq, void *offset)
 				buff_pos += sprintf(buff + buff_pos, "%pM,",
 						entry->addr);
 
-				for (i = 0; i < packet->entries; i++)
+				for (j = 0; j < packet->entries; j++)
 					buff_pos += vis_data_read_entry(
 							buff + buff_pos,
-							&entries[i],
+							&entries[j],
 							entry->addr,
 							entry->primary);
 
-- 
1.7.2.3


  reply	other threads:[~2011-01-30  9:38 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-29 21:47 pull request: batman-adv 2011-01-29 Sven Eckelmann
2011-01-29 21:47 ` [B.A.T.M.A.N.] " Sven Eckelmann
     [not found] ` <1296337660-12376-1-git-send-email-sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
2011-01-29 21:47   ` [PATCH 01/13] batman-adv: Fix kernel panic when fetching vis data on a vis server Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 02/13] batman-adv: Create roughly equal sized fragments Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 03/13] batman-adv: Calculate correct size for merged packets Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 04/13] batman-adv: Remove vis info on hashing errors Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 05/13] batman-adv: Remove vis info element in free_info Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 06/13] batman-adv: Make vis info stack traversal threadsafe Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 07/13] batman-adv: remove unused parameters Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 08/13] batman-adv: Remove dangling declaration of hash_remove_element Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 09/13] batman-adv: Remove unused definitions Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 10/13] batman-adv: Remove declaration of batman_skb_recv Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 11/13] batman-adv: Remove unused variables Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 12/13] batman-adv: Update copyright years Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-29 21:47   ` [PATCH 13/13] batman-adv: Merge README of v2011.0.0 release Sven Eckelmann
2011-01-29 21:47     ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-30  3:08   ` pull request: batman-adv 2011-01-29 David Miller
2011-01-30  3:08     ` [B.A.T.M.A.N.] " David Miller
     [not found]     ` <20110129.190815.226768755.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2011-01-30  9:36       ` Sven Eckelmann
2011-01-30  9:36         ` [B.A.T.M.A.N.] " Sven Eckelmann
2011-01-30  9:38         ` Sven Eckelmann [this message]
2011-01-30  9:38         ` [PATCH 2/4] batman-adv: Remove vis info on hashing errors Sven Eckelmann
2011-01-30  9:38         ` [PATCH 3/4] batman-adv: Remove vis info element in free_info Sven Eckelmann
2011-01-30  9:38         ` [PATCH 4/4] batman-adv: Make vis info stack traversal threadsafe Sven Eckelmann
     [not found]         ` <201101301036.57928.sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org>
2011-01-30 11:56           ` pull request: batman-adv 2011-01-29 David Miller
2011-01-30 11:56             ` [B.A.T.M.A.N.] " David Miller
2011-01-30 12:11 pull request: batman-adv 2011-01-30 Sven Eckelmann
2011-01-30 12:11 ` [PATCH 1/4] batman-adv: Fix kernel panic when fetching vis data on a vis server Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296380332-4269-1-git-send-email-sven@narfation.org \
    --to=sven@narfation.org \
    --cc=davem@davemloft.net \
    --cc=linus.luessing@web.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.