All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@free.fr>
To: akpm@linux-foundation.org
Cc: ebiederm@xmission.com, oleg@redhat.com,
	containers@lists.linux-foundation.org,
	linux-kernel@vger.kernel.org, clg@fr.ibm.com
Subject: [PATCH 3/4] procfs: kill the global proc_mnt variable
Date: Mon, 31 Jan 2011 11:25:24 +0100	[thread overview]
Message-ID: <1296469525-30111-4-git-send-email-daniel.lezcano@free.fr> (raw)
In-Reply-To: <1296469525-30111-1-git-send-email-daniel.lezcano@free.fr>

From: Oleg Nesterov <oleg@redhat.com>

After the previous cleanup in proc_get_sb() the global proc_mnt has
no reasons to exists, kill it.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@free.fr>
---
 fs/proc/inode.c    |    2 --
 fs/proc/internal.h |    1 -
 fs/proc/root.c     |    7 ++++---
 3 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 176ce4c..ee0f802 100644
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -42,8 +42,6 @@ static void proc_evict_inode(struct inode *inode)
 		sysctl_head_put(PROC_I(inode)->sysctl);
 }
 
-struct vfsmount *proc_mnt;
-
 static struct kmem_cache * proc_inode_cachep;
 
 static struct inode *proc_alloc_inode(struct super_block *sb)
diff --git a/fs/proc/internal.h b/fs/proc/internal.h
index 9ad561d..c03e8d3 100644
--- a/fs/proc/internal.h
+++ b/fs/proc/internal.h
@@ -107,7 +107,6 @@ static inline struct proc_dir_entry *pde_get(struct proc_dir_entry *pde)
 }
 void pde_put(struct proc_dir_entry *pde);
 
-extern struct vfsmount *proc_mnt;
 int proc_fill_super(struct super_block *);
 struct inode *proc_get_inode(struct super_block *, struct proc_dir_entry *);
 
diff --git a/fs/proc/root.c b/fs/proc/root.c
index e5e2bfa..a9000e9 100644
--- a/fs/proc/root.c
+++ b/fs/proc/root.c
@@ -90,19 +90,20 @@ static struct file_system_type proc_fs_type = {
 
 void __init proc_root_init(void)
 {
+	struct vfsmount *mnt;
 	int err;
 
 	proc_init_inodecache();
 	err = register_filesystem(&proc_fs_type);
 	if (err)
 		return;
-	proc_mnt = kern_mount_data(&proc_fs_type, &init_pid_ns);
-	if (IS_ERR(proc_mnt)) {
+	mnt = kern_mount_data(&proc_fs_type, &init_pid_ns);
+	if (IS_ERR(mnt)) {
 		unregister_filesystem(&proc_fs_type);
 		return;
 	}
 
-	init_pid_ns.proc_mnt = proc_mnt;
+	init_pid_ns.proc_mnt = mnt;
 	proc_symlink("mounts", NULL, "self/mounts");
 
 	proc_net_init();
-- 
1.7.1


  parent reply	other threads:[~2011-01-31 10:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-31 10:25 Prepare for the unshare support of the pid namespace Daniel Lezcano
2011-01-31 10:25 ` [PATCH 1/4] pid: Remove the child_reaper special case in init/main.c Daniel Lezcano
2011-01-31 10:25 ` [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace Daniel Lezcano
     [not found]   ` <1296469525-30111-3-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 13:22     ` Oleg Nesterov
2011-01-31 13:22   ` Oleg Nesterov
     [not found]     ` <20110131132207.GA26995-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-01-31 13:33       ` Daniel Lezcano
2011-01-31 13:33     ` Daniel Lezcano
     [not found]       ` <4D46BA25.8080201-GANU6spQydw@public.gmane.org>
2011-01-31 14:02         ` Oleg Nesterov
2011-01-31 14:02       ` Oleg Nesterov
2011-01-31 14:21         ` Daniel Lezcano
     [not found]         ` <20110131140257.GA28827-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-01-31 14:21           ` Daniel Lezcano
     [not found] ` <1296469525-30111-1-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 10:25   ` [PATCH 1/4] pid: Remove the child_reaper special case in init/main.c Daniel Lezcano
2011-01-31 10:25   ` [PATCH 2/4] pidns: Call pid_ns_prepare_proc from create_pid_namespace Daniel Lezcano
2011-01-31 10:25   ` [PATCH 3/4] procfs: kill the global proc_mnt variable Daniel Lezcano
2011-01-31 10:25   ` [PATCH 4/4] pidns: Use task_active_pid_ns where appropriate Daniel Lezcano
2011-01-31 10:25 ` Daniel Lezcano [this message]
2011-01-31 10:25 ` Daniel Lezcano
2011-01-31 11:26   ` Alexey Dobriyan
2011-01-31 14:47     ` Daniel Lezcano
2011-01-31 15:36       ` Oleg Nesterov
2011-02-01 10:07         ` Daniel Lezcano
     [not found]         ` <20110131153653.GA32392-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-02-01 10:07           ` Daniel Lezcano
     [not found]       ` <4D46CB9E.1090802-GANU6spQydw@public.gmane.org>
2011-01-31 15:36         ` Oleg Nesterov
     [not found]     ` <AANLkTikjcou-0b4NejpY66qXeZuzsC-M+oNTyHk=OE-Z-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-01-31 14:47       ` Daniel Lezcano
     [not found]   ` <1296469525-30111-5-git-send-email-daniel.lezcano-GANU6spQydw@public.gmane.org>
2011-01-31 11:26     ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1296469525-30111-4-git-send-email-daniel.lezcano@free.fr \
    --to=daniel.lezcano@free.fr \
    --cc=akpm@linux-foundation.org \
    --cc=clg@fr.ibm.com \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.