From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.nokia.com ([147.243.128.26]:27237 "EHLO mgw-da02.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334Ab1BGN1i (ORCPT ); Mon, 7 Feb 2011 08:27:38 -0500 Subject: Re: WL1273 FM Radio driver... From: "Matti J. Aaltonen" Reply-To: matti.j.aaltonen@nokia.com To: ext Mauro Carvalho Chehab Cc: Mark Brown , alsa-devel@alsa-project.org, lrg@slimlogic.co.uk, hverkuil@xs4all.nl, sameo@linux.intel.com, linux-media@vger.kernel.org In-Reply-To: <4D4FEA03.7090109@redhat.com> References: <1297075922.15320.31.camel@masi.mnp.nokia.com> <4D4FDED0.7070008@redhat.com> <20110207120234.GE10564@opensource.wolfsonmicro.com> <4D4FEA03.7090109@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 07 Feb 2011 15:27:12 +0200 Message-ID: <1297085233.15320.39.camel@masi.mnp.nokia.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit List-ID: Sender: On Mon, 2011-02-07 at 10:48 -0200, ext Mauro Carvalho Chehab wrote: > Em 07-02-2011 10:02, Mark Brown escreveu: > > On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote: > > > >> the MFD part (for example, wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data). > >> The logic that are related to control the radio (wl1273_fm_set_audio, wl1273_fm_set_volume, > >> etc) are not related to access the device via the MFD bus. They should be at > >> the media part of the driver, where they belong. > > > > Those functions are being used by the audio driver. > > Not sure if I understood your comments. Several media drivers have alsa drivers: > saa7134, em28xx, cx231xx, etc. The audio drivers for them are also under > /drivers/media, as it is not easy to de-couple audio and video/radio part > on those devices. For bttv and some USB boards (that use snd-usb-audio), the audio > part is at /sound, as the audio part on them are independent and don't need to > share anything, as audio is provided by a completely independent group of > registers. > > I suggest to use the same logic for wl1273. So you are suggesting a more or less complete rewrite, so that I'd create a directory like media/radio/wl1273 and then place there all of the driver files: wl1273-radio.c, wl1273-alsa.c and maybe wl1273-core.c? Cheers, Matti > > Cheers, > Mauro. > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Matti J. Aaltonen" Subject: Re: WL1273 FM Radio driver... Date: Mon, 07 Feb 2011 15:27:12 +0200 Message-ID: <1297085233.15320.39.camel@masi.mnp.nokia.com> References: <1297075922.15320.31.camel@masi.mnp.nokia.com> <4D4FDED0.7070008@redhat.com> <20110207120234.GE10564@opensource.wolfsonmicro.com> <4D4FEA03.7090109@redhat.com> Reply-To: matti.j.aaltonen@nokia.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mgw-da02.nokia.com (smtp.nokia.com [147.243.128.26]) by alsa0.perex.cz (Postfix) with ESMTP id 5C86524179 for ; Mon, 7 Feb 2011 14:27:19 +0100 (CET) In-Reply-To: <4D4FEA03.7090109@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: ext Mauro Carvalho Chehab Cc: alsa-devel@alsa-project.org, sameo@linux.intel.com, Mark Brown , hverkuil@xs4all.nl, lrg@slimlogic.co.uk, linux-media@vger.kernel.org List-Id: alsa-devel@alsa-project.org On Mon, 2011-02-07 at 10:48 -0200, ext Mauro Carvalho Chehab wrote: > Em 07-02-2011 10:02, Mark Brown escreveu: > > On Mon, Feb 07, 2011 at 10:00:16AM -0200, Mauro Carvalho Chehab wrote: > > > >> the MFD part (for example, wl1273_fm_read_reg/wl1273_fm_write_cmd/wl1273_fm_write_data). > >> The logic that are related to control the radio (wl1273_fm_set_audio, wl1273_fm_set_volume, > >> etc) are not related to access the device via the MFD bus. They should be at > >> the media part of the driver, where they belong. > > > > Those functions are being used by the audio driver. > > Not sure if I understood your comments. Several media drivers have alsa drivers: > saa7134, em28xx, cx231xx, etc. The audio drivers for them are also under > /drivers/media, as it is not easy to de-couple audio and video/radio part > on those devices. For bttv and some USB boards (that use snd-usb-audio), the audio > part is at /sound, as the audio part on them are independent and don't need to > share anything, as audio is provided by a completely independent group of > registers. > > I suggest to use the same logic for wl1273. So you are suggesting a more or less complete rewrite, so that I'd create a directory like media/radio/wl1273 and then place there all of the driver files: wl1273-radio.c, wl1273-alsa.c and maybe wl1273-core.c? Cheers, Matti > > Cheers, > Mauro. > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html