From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Meneghel Rodrigues Subject: Re: [KVM-AUTOTEST PATCH] KVM test: refactor kvm_config.py Date: Thu, 10 Feb 2011 10:42:40 -0200 Message-ID: <1297341760.2605.9.camel@freedom> References: <1297216207-28375-1-git-send-email-mgoldish@redhat.com> <4D525E58.4080009@redhat.com> <20110210011847.GA1118@t173.nay.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: Avi Kivity , Michael Goldish , autotest@test.kernel.org, kvm@vger.kernel.org, Uri Lublin To: Amos Kong Return-path: Received: from mx1.redhat.com ([209.132.183.28]:27481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752353Ab1BJMmo (ORCPT ); Thu, 10 Feb 2011 07:42:44 -0500 In-Reply-To: <20110210011847.GA1118@t173.nay.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 2011-02-10 at 09:18 +0800, Amos Kong wrote: > On Wed, Feb 09, 2011 at 11:28:56AM +0200, Avi Kivity wrote: > > On 02/09/2011 03:50 AM, Michael Goldish wrote: > > >This is a reimplementation of the dict generator. It is much faster than the > > >current implementation and uses a very small amount of memory. Running time > > >and memory usage scale polynomially with the number of defined variants, > > >compared to exponentially in the current implementation. > > > > > >Instead of regular expressions in the filters, the following syntax is used: > > > > > >, means OR > > >.. means AND > > >. means IMMEDIATELY-FOLLOWED-BY > > > > > >Example: > > > > > >only qcow2..Fedora.14, RHEL.6..raw..boot, smp2..qcow2..migrate..ide > > > > > > > > > Is it not possible to keep the old syntax? Breaking people's > > scripts is bad. > > we only need convert the configure file, it's not too complex Yes, the benefits of the new format outnumber the inconveniences. As for my opinion on the operator, .. is sufficiently clear and expressive to do most of the stuff we need to do with configuration anyway.