From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36652 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnYmI-0000WM-QV for qemu-devel@nongnu.org; Thu, 10 Feb 2011 10:49:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnYmA-0007y8-A3 for qemu-devel@nongnu.org; Thu, 10 Feb 2011 10:49:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnYmA-0007xi-2K for qemu-devel@nongnu.org; Thu, 10 Feb 2011 10:49:46 -0500 From: Kevin Wolf Date: Thu, 10 Feb 2011 16:51:18 +0100 Message-Id: <1297353086-4844-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1297353086-4844-1-git-send-email-kwolf@redhat.com> References: <1297353086-4844-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 03/11] qcow2: Fix error handling for immediate backing file read failure List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org Requests could return success even though they failed when bdrv_aio_readv returned NULL for a backing file read. Reported-by: Chunqiang Tang Signed-off-by: Kevin Wolf --- block/qcow2.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 28338bf..647c2a4 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -479,8 +479,10 @@ static void qcow2_aio_read_cb(void *opaque, int ret) BLKDBG_EVENT(bs->file, BLKDBG_READ_BACKING_AIO); acb->hd_aiocb = bdrv_aio_readv(bs->backing_hd, acb->sector_num, &acb->hd_qiov, n1, qcow2_aio_read_cb, acb); - if (acb->hd_aiocb == NULL) + if (acb->hd_aiocb == NULL) { + ret = -EIO; goto done; + } } else { ret = qcow2_schedule_bh(qcow2_aio_read_bh, acb); if (ret < 0) -- 1.7.2.3