From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752928Ab1BJSUj (ORCPT ); Thu, 10 Feb 2011 13:20:39 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:50164 "EHLO e2.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917Ab1BJSUi (ORCPT ); Thu, 10 Feb 2011 13:20:38 -0500 Subject: Re: [PATCH 5/5] have smaps show transparent huge pages From: Dave Hansen To: Andrea Arcangeli Cc: Mel Gorman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael J Wolf , Johannes Weiner , David Rientjes In-Reply-To: <20110210180924.GB3347@random.random> References: <20110209195406.B9F23C9F@kernel> <20110209195413.6D3CB37F@kernel> <20110210112032.GG17873@csn.ul.ie> <1297350115.6737.14208.camel@nimitz> <20110210150942.GL17873@csn.ul.ie> <20110210180924.GB3347@random.random> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Thu, 10 Feb 2011 10:20:32 -0800 Message-ID: <1297362032.6737.14622.camel@nimitz> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Content-Scanned: Fidelis XPS MAILER Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-02-10 at 19:09 +0100, Andrea Arcangeli wrote: > Maybe it'd be cleaner if we didn't need to cast the pmd to pte_t but I > guess this makes things simpler. Yeah, I'm not a huge fan of doing that, either. But, I'm not sure what the alternatives are. We could basically copy smaps_pte_entry() to smaps_pmd_entry(), and then try to make pmd variants of all of the pte functions and macros we call in there. I know there's a least a bit of precedent in the hugetlbfs code for doing things like this, but it's not a _great_ excuse. :) -- Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id 5F6CB8D0039 for ; Thu, 10 Feb 2011 13:20:39 -0500 (EST) Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p1AI1gPt030881 for ; Thu, 10 Feb 2011 13:02:43 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 618E34DE804A for ; Thu, 10 Feb 2011 13:19:45 -0500 (EST) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p1AIKa8l322160 for ; Thu, 10 Feb 2011 13:20:36 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p1AIKZDn021446 for ; Thu, 10 Feb 2011 13:20:36 -0500 Subject: Re: [PATCH 5/5] have smaps show transparent huge pages From: Dave Hansen In-Reply-To: <20110210180924.GB3347@random.random> References: <20110209195406.B9F23C9F@kernel> <20110209195413.6D3CB37F@kernel> <20110210112032.GG17873@csn.ul.ie> <1297350115.6737.14208.camel@nimitz> <20110210150942.GL17873@csn.ul.ie> <20110210180924.GB3347@random.random> Content-Type: text/plain; charset="ANSI_X3.4-1968" Date: Thu, 10 Feb 2011 10:20:32 -0800 Message-ID: <1297362032.6737.14622.camel@nimitz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Andrea Arcangeli Cc: Mel Gorman , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Michael J Wolf , Johannes Weiner , David Rientjes On Thu, 2011-02-10 at 19:09 +0100, Andrea Arcangeli wrote: > Maybe it'd be cleaner if we didn't need to cast the pmd to pte_t but I > guess this makes things simpler. Yeah, I'm not a huge fan of doing that, either. But, I'm not sure what the alternatives are. We could basically copy smaps_pte_entry() to smaps_pmd_entry(), and then try to make pmd variants of all of the pte functions and macros we call in there. I know there's a least a bit of precedent in the hugetlbfs code for doing things like this, but it's not a _great_ excuse. :) -- Dave -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org