All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Sumit Semwal <sumit.semwal@ti.com>
Cc: tomi.valkeinen@nokia.com, paul@pwsan.com, khilman@ti.com,
	hvaibhav@ti.com, linux-omap@vger.kernel.org, b-cousson@ti.com,
	Mayuresh Janorkar <mayur@ti.com>
Subject: Re: [v3,1/3] OMAP2PLUS: DSS2: Add OMAP4 Kconfig support
Date: Fri, 11 Feb 2011 14:06:03 +0200	[thread overview]
Message-ID: <1297425963.9552.305.camel@deskari> (raw)
In-Reply-To: <1296127024-17507-2-git-send-email-sumit.semwal@ti.com>

Hi,

On Thu, 2011-01-27 at 11:17 +0000, Sumit Semwal wrote:
> From: Mayuresh Janorkar <mayur@ti.com>
> 
> Enable DSS2 and OMAPFB for OMAP4 in Kconfig

The indentation in this patch seems to be a bit inconsistent with the
current Kconfigs. For example, you use two tabs in the help lines, and
the current files use either one tab and 2 spaces, or 10 spaces.

Please stick to the current indentation, or change the indentation for
the whole file in a separate patch.

 Tomi



  reply	other threads:[~2011-02-11 12:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 11:17 [PATCH v3 0/3] OMAP4: hwmod DSS support Sumit Semwal
2011-01-27 11:17 ` [PATCH v3 1/3] OMAP2PLUS: DSS2: Add OMAP4 Kconfig support Sumit Semwal
2011-02-11 12:06   ` Tomi Valkeinen [this message]
2011-02-16  4:56     ` [v3,1/3] " Semwal, Sumit
2011-01-27 11:17 ` [PATCH v3 2/3] OMAP4: hwmod data: add DSS DISPC DSI1,2 RFBI HDMI VENC Sumit Semwal
2011-02-11 16:50   ` Cousson, Benoit
2011-02-14 18:52     ` Semwal, Sumit
2011-01-27 11:17 ` [PATCH v3 3/3] OMAP4: DSS2: Add hwmod device names for OMAP4 Sumit Semwal
2011-02-11 12:23 ` [PATCH v3 0/3] OMAP4: hwmod DSS support Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297425963.9552.305.camel@deskari \
    --to=tomi.valkeinen@ti.com \
    --cc=b-cousson@ti.com \
    --cc=hvaibhav@ti.com \
    --cc=khilman@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mayur@ti.com \
    --cc=paul@pwsan.com \
    --cc=sumit.semwal@ti.com \
    --cc=tomi.valkeinen@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.