From: <christophe.lyon@st.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/6] target-arm: fix saturated values for Neon right shifts.
Date: Fri, 11 Feb 2011 16:11:00 +0100 [thread overview]
Message-ID: <1297437062-6118-5-git-send-email-christophe.lyon@st.com> (raw)
In-Reply-To: <1297437062-6118-1-git-send-email-christophe.lyon@st.com>
From: Christophe Lyon <christophe.lyon@st.com>
Fix value returned by signed qrshl helpers (8, 16 and 32 bits).
Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
---
target-arm/neon_helper.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/target-arm/neon_helper.c b/target-arm/neon_helper.c
index 907f7b7..83d610a 100644
--- a/target-arm/neon_helper.c
+++ b/target-arm/neon_helper.c
@@ -903,7 +903,7 @@ uint64_t HELPER(neon_qrshl_u64)(CPUState *env, uint64_t val, uint64_t shiftop)
dest = src1 << tmp; \
if ((dest >> tmp) != src1) { \
SET_QC(); \
- dest = src1 >> 31; \
+ dest = (uint32_t)(1 << (sizeof(src1) * 8 - 1)) - (src1 > 0 ? 1 : 0); \
} \
}} while (0)
NEON_VOP_ENV(qrshl_s8, neon_s8, 4)
@@ -924,7 +924,11 @@ uint32_t HELPER(neon_qrshl_s32)(CPUState *env, uint32_t valop, uint32_t shiftop)
dest = val << shift;
if ((dest >> shift) != val) {
SET_QC();
- dest = (uint32_t)(1 << (sizeof(val) * 8 - 1)) - (val > 0 ? 1 : 0);
+ if (val < 0) {
+ dest = INT32_MIN;
+ } else {
+ dest = INT32_MAX;
+ }
}
}
return dest;
--
1.7.2.3
next prev parent reply other threads:[~2011-02-11 15:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-11 15:10 [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions christophe.lyon
2011-02-11 15:10 ` [Qemu-devel] [PATCH 1/6] target-arm: Fix rounding constant addition for " christophe.lyon
2011-02-14 18:12 ` Peter Maydell
2011-02-15 10:07 ` Christophe Lyon
2011-02-11 15:10 ` [Qemu-devel] [PATCH 2/6] target-arm: fix Neon right shifts with shift amount == input width christophe.lyon
2011-02-14 18:16 ` Peter Maydell
2011-02-15 13:47 ` Christophe Lyon
2011-02-11 15:10 ` [Qemu-devel] [PATCH 3/6] target-arm: fix unsigned 64 bit right shifts christophe.lyon
2011-02-14 17:40 ` Peter Maydell
2011-02-11 15:11 ` christophe.lyon [this message]
2011-02-14 17:46 ` [Qemu-devel] [PATCH 4/6] target-arm: fix saturated values for Neon " Peter Maydell
2011-02-14 17:49 ` Peter Maydell
2011-02-15 14:06 ` Christophe Lyon
2011-02-11 15:11 ` [Qemu-devel] [PATCH 5/6] target-arm: fix Neon VQSHRN and VSHRN christophe.lyon
2011-02-14 17:41 ` Peter Maydell
2011-02-11 15:11 ` [Qemu-devel] [PATCH 6/6] target-arm: fix decoding of Neon 64 bit shifts christophe.lyon
2011-02-14 17:53 ` Peter Maydell
2011-02-14 18:18 ` [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift instructions Peter Maydell
2011-02-15 14:03 ` Christophe Lyon
2011-02-15 14:21 ` Peter Maydell
2011-02-15 14:49 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297437062-6118-5-git-send-email-christophe.lyon@st.com \
--to=christophe.lyon@st.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.