From: martin.xu@intel.com
To: ofono@ofono.org
Subject: [V3 PATCH 2/3] PPP: Use default ACCM (0xffffffff) to trasmit package
Date: Sat, 12 Feb 2011 17:41:14 +0800 [thread overview]
Message-ID: <1297503675-32491-2-git-send-email-martin.xu@intel.com> (raw)
In-Reply-To: <1297503675-32491-1-git-send-email-martin.xu@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1465 bytes --]
From: Martin Xu <martin.xu@intel.com>
Using my Huawei EM770W modem, if set ACCM as 0x00000000, RXJ-
event breaks PPP link, after IP package transmit for a while.
Using default ACCM, the issue can be fixed.
I tested it at China Unicom networks.
---
gatchat/ppp_lcp.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c
index cc3e231..91a8b67 100644
--- a/gatchat/ppp_lcp.c
+++ b/gatchat/ppp_lcp.c
@@ -105,8 +105,7 @@ static void lcp_generate_config_options(struct lcp_data *lcp)
static void lcp_reset_config_options(struct lcp_data *lcp)
{
- lcp->req_options = REQ_OPTION_ACCM;
- lcp->accm = 0;
+ /* Using the default ACCM */
lcp_generate_config_options(lcp);
}
@@ -147,6 +146,7 @@ static void lcp_rca(struct pppcp_data *pppcp, const struct pppcp_packet *packet)
ppp_option_iter_init(&iter, packet);
while (ppp_option_iter_next(&iter) == TRUE) {
+ const guint8 *data = ppp_option_iter_get_data(&iter);
switch (ppp_option_iter_get_type(&iter)) {
case ACCM:
/*
@@ -155,7 +155,9 @@ static void lcp_rca(struct pppcp_data *pppcp, const struct pppcp_packet *packet)
* which control characters MUST remain mapped when
* the peer sends them.
*/
- ppp_set_recv_accm(pppcp_get_ppp(pppcp), 0);
+
+ ppp_set_recv_accm(pppcp_get_ppp(pppcp),
+ pppcpget_host_long(data));
break;
default:
break;
--
1.6.1.3
next prev parent reply other threads:[~2011-02-12 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-12 9:41 [V3 PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue martin.xu
2011-02-12 9:41 ` martin.xu [this message]
2011-02-12 9:41 ` [V3 PATCH 3/3] Huawei: set Huawei EM770W modem device to 00 martin.xu
2011-02-14 20:28 ` Denis Kenzior
2011-02-15 7:03 ` Xu, Martin
2011-02-16 18:04 ` Denis Kenzior
2011-02-17 2:19 ` Marcel Holtmann
2011-02-14 20:26 ` [V3 PATCH 2/3] PPP: Use default ACCM (0xffffffff) to trasmit package Denis Kenzior
2011-02-14 20:25 ` [V3 PATCH 1/3] PPP: Fix transmit ACCM and receive ACCM setting issue Denis Kenzior
2011-02-15 6:53 [V3 PATCH 2/3] PPP: Use default ACCM (0xffffffff) to trasmit package martin.xu
2011-02-16 18:02 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297503675-32491-2-git-send-email-martin.xu@intel.com \
--to=martin.xu@intel.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.