From: Johannes Berg <johannes@sipsolutions.net>
To: Felix Fietkau <nbd@openwrt.org>
Cc: linux-wireless@vger.kernel.org, j@w1.fi, lrodriguez@atheros.com,
m.sujith@gmail.com
Subject: Re: [RFC v2 1/2] mac80211: add a function for setting the TIM bit for a specific station
Date: Mon, 14 Feb 2011 15:08:14 +0100 [thread overview]
Message-ID: <1297692494.3953.0.camel@jlt3.sipsolutions.net> (raw)
In-Reply-To: <4D5936D8.3030906@openwrt.org>
On Mon, 2011-02-14 at 15:06 +0100, Felix Fietkau wrote:
> On 2011-02-14 1:09 PM, Johannes Berg wrote:
> > On Wed, 2011-02-09 at 00:32 +0100, Felix Fietkau wrote:
> >> When a driver wants to buffer some frames internally without feeding them
> >> back to mac80211, this allows it to still wake up the station
> >
> > Why would the driver want to do this though?
> If a station enters powersave and the AP still has buffered frames for
> aggregation, those frames need to stay in the queue, since the driver
> controls the block ack window and keeps some state per frame (e.g.
> number of software retransmissions).
> If ath9k would send those frames back to mac80211, and mac80211 would
> drop some of them, then the client's reorder window would get messed up
> when the client comes back. This would also make managing frame sequence
> numbers more complicated, since the driver would have to skip assigning
> sequence numbers for frames where tx_info->flags has the
> IEEE80211_TX_INTFL_RETRANSMISSION bit set, but then also look for gaps
> caused by expired frames.
Ok, that makes sense. In fact, I think iwlwifi will have the same issue
since it buffers in hw queues... will have to check that.
johannes
next prev parent reply other threads:[~2011-02-14 14:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 23:32 [RFC v2 1/2] mac80211: add a function for setting the TIM bit for a specific station Felix Fietkau
2011-02-08 23:32 ` [RFC v2 2/2] ath9k: fix powersave frame filtering/buffering in AP mode Felix Fietkau
2011-02-14 12:09 ` [RFC v2 1/2] mac80211: add a function for setting the TIM bit for a specific station Johannes Berg
2011-02-14 14:06 ` Felix Fietkau
2011-02-14 14:08 ` Johannes Berg [this message]
2011-02-14 14:38 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297692494.3953.0.camel@jlt3.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=j@w1.fi \
--cc=linux-wireless@vger.kernel.org \
--cc=lrodriguez@atheros.com \
--cc=m.sujith@gmail.com \
--cc=nbd@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.