All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: [PATCH 2/3] KVM: VMX: Short circuit STI; HLT while an interrupt is pending
Date: Mon, 14 Feb 2011 16:42:16 +0200	[thread overview]
Message-ID: <1297694537-9268-3-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1297694537-9268-1-git-send-email-avi@redhat.com>

Short-circuit an STI; HLT sequence while an interrupt is pending:
instead of halting, re-entering the guest, and exiting immediately
on an interrupt window exit, go directly to the last step.

Saves a vmexit on workloads where interrupts are received synchronously;
an example is a disk backed by the host page cache where there is no
latency (from the guest's point of view) between the request and fulfilment.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 arch/x86/kvm/vmx.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
index ee1cd1a..541da0e 100644
--- a/arch/x86/kvm/vmx.c
+++ b/arch/x86/kvm/vmx.c
@@ -3437,6 +3437,15 @@ static int handle_interrupt_window(struct kvm_vcpu *vcpu)
 static int handle_halt(struct kvm_vcpu *vcpu)
 {
 	skip_emulated_instruction(vcpu);
+	/*
+	 * Short-circuit an STI; HLT sequence while an interrupt is pending:
+	 * instead of halting, re-entering the guest, and exiting immediately
+	 * on an interrupt window exit, go directly to the last step.
+	 */
+	if ((to_vmx(vcpu)->cpu_based_vm_exec_control
+	     & CPU_BASED_VIRTUAL_INTR_PENDING)
+	    && (kvm_get_rflags(vcpu) & X86_EFLAGS_IF))
+		return handle_interrupt_window(vcpu);
 	return kvm_emulate_halt(vcpu);
 }
 
-- 
1.7.1


  parent reply	other threads:[~2011-02-14 14:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-14 14:42 [PATCH 0/3] Optimize STI; HLT while an interrupt is pending Avi Kivity
2011-02-14 14:42 ` [PATCH 1/3] KVM: VMX: Cache CPU_BASED_VM_EXEC_CONTROL VMCS field Avi Kivity
2011-02-14 14:42 ` Avi Kivity [this message]
2011-02-15 20:36   ` [PATCH 2/3] KVM: VMX: Short circuit STI; HLT while an interrupt is pending Marcelo Tosatti
2011-02-16  9:01     ` Avi Kivity
2011-02-16 16:51       ` Marcelo Tosatti
2011-02-17  9:12         ` Avi Kivity
2011-02-17 16:16           ` Marcelo Tosatti
2011-02-20  9:04             ` Avi Kivity
2011-02-14 14:42 ` [PATCH 3/3] KVM: SVM: " Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297694537-9268-3-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.