From: Artem Bityutskiy <dedekind1@gmail.com>
To: Jarkko Lavinen <jarkko.lavinen@nokia.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH 3/3] mtd: Add mtdswap block driver
Date: Fri, 25 Feb 2011 13:03:49 +0200 [thread overview]
Message-ID: <1298631829.2798.59.camel@localhost> (raw)
In-Reply-To: <20110222162143.GA13529@angel.research.nokia.com>
On Tue, 2011-02-22 at 18:21 +0200, Jarkko Lavinen wrote:
> On Fri, Feb 18, 2011 at 04:14:30PM +0200, ext Artem Bityutskiy wrote:
> > ... what's the problem with re-trying the erase operation - it
> > looks like over-design.
>
> > Is it please possible to remove this config option?
>
> I have a Hynix SLC OneNand spec which says an erase block with an
> erase failure or a write error should not be re-written or erased
> again but instead just garbage collected and marked bad.
>
> If I switch permanently to the strict erase failure handling, bad
> block marking could be too sensitive for some devices expecting
> retries.
>
> If I switch permanently to the lenient mode, mtdswap would retry
> failed erases which would be against chip spec of at least the one
> OneNand chip I am working with.
>
> If I remove the config option it would then mean strict handling
> only.
Please, make the option to be a module parameter.
And add this description to the parameter description. Probably this
amount of text is too much for MODULE_PARM_DESC() - put less there, and
put the details to a comment near that MODULE_PARM_DESC().
IOW, I'm not against this option, I'm against making it Kconfig option.
Thanks a lot!
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
next prev parent reply other threads:[~2011-02-25 11:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 14:16 Jarkko Lavinen
2011-02-14 14:16 ` [PATCH 1/3] mtd_blkdevs: Add background processing support Jarkko Lavinen
2011-02-14 14:16 ` [PATCH 2/3] mtd_blkdevs: Set the maximum discards size Jarkko Lavinen
2011-02-14 14:16 ` [PATCH 3/3] mtd: Add mtdswap block driver Jarkko Lavinen
2011-02-18 14:14 ` Artem Bityutskiy
2011-02-22 16:21 ` Jarkko Lavinen
2011-02-25 11:03 ` Artem Bityutskiy [this message]
2011-03-09 8:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298631829.2798.59.camel@localhost \
--to=dedekind1@gmail.com \
--cc=jarkko.lavinen@nokia.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.