All of lore.kernel.org
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx5: forbid building i.MX51 with any of i.MX50 or i.MX53
Date: Tue,  1 Mar 2011 22:07:28 +0100	[thread overview]
Message-ID: <1299013648-26630-1-git-send-email-u.kleine-koenig@pengutronix.de> (raw)

A config supporting all three SoCs compiles just fine, but the image
is broken because of different PHYS_OFFSETs.

This fix is a bit ugly because the i.MX50/i.MX53 machines simply
disappear in the config system when the first i.MX51 machine is
selected, but the upside is that no additional Kconfig symbol is
needed which would break more configs than this change.

Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
---
 arch/arm/mach-mx5/Kconfig |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-mx5/Kconfig b/arch/arm/mach-mx5/Kconfig
index f065a0d..4419f76 100644
--- a/arch/arm/mach-mx5/Kconfig
+++ b/arch/arm/mach-mx5/Kconfig
@@ -135,6 +135,11 @@ config MACH_MX51_EFIKASB
 	  Include support for Genesi Efika Smartbook. This includes specific
 	  configurations for the board and its peripherals.
 
+# i.MX51 uses a different PHYS_OFFSET than i.MX50 and i.MX53, so until this is
+# supported in a single kernel forbid selecting i.MX50/i.MX53 bases machines
+# when a i.MX51 based one is already selected.
+if !SOC_IMX51
+
 config MACH_MX53_EVK
 	bool "Support MX53 EVK platforms"
 	select SOC_IMX53
@@ -180,3 +185,5 @@ config MACH_MX50_RDP
 	  includes specific configurations for the board and its peripherals.
 
 endif
+
+endif
-- 
1.7.2.3

                 reply	other threads:[~2011-03-01 21:07 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299013648-26630-1-git-send-email-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.