From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD9C5C433EF for ; Wed, 6 Apr 2022 02:03:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wQkNjqwTI2dJusr7Mx/SS/nfXG0HXH3xEZCR4jvJzKY=; b=wXQ3lWsnlENUo5 AUb1gk6WbeAQztnRcWzz7dJDJ8SPYOMorCcnJsekc/o0PN1LBHx/HnGWJ2xs9d1Zcyum+KTmgvG7R exvoEcSRCNxDF7IxlmreZA6az+nufH7wD5gpBclqaGppjSfDhdo9Pl1tsKLrQqTB+YgQqSAg85ZH+ uURxb7pSyR7TTsilJoK7SHW5lrR4XzCErbzaYTZa2bcYN6TzvgyS9ELrVZfViN4icz895o+fl0VQo ns/bEc431IpdEGKtMYjwj93dnw0L3OKCV5Xk28Dycc1Nv208H3X980Ed+m9xCpVfv8bLKUM1W9T9/ 7PI7k0AMV8YNFTdjfy5A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbv0v-003JwQ-8n; Wed, 06 Apr 2022 02:03:17 +0000 Received: from mail-m17637.qiye.163.com ([59.111.176.37]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbv0h-003Jq0-Sj; Wed, 06 Apr 2022 02:03:05 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id F0DA798048A; Wed, 6 Apr 2022 10:02:59 +0800 (CST) Message-ID: <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> Date: Wed, 6 Apr 2022 10:02:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer Cc: Piotr Oniszczuk , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220405093700.GQ4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlIGEtWGE1LSkpOGB oYSkhIVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MRA6GCo5Aj4MHUsIMBYxFThK NDYwCjNVSlVKTU9CSUpLTkNLTUxIVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTklNSjcG X-HM-Tid: 0a7ffc9c5db9d992kuwsf0da798048a X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220405_190304_138314_327E1A59 X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGk6CgpPbiA0LzUvMjIgMTc6MzcsIFNhc2NoYSBIYXVlciB3cm90ZToKPiBPbiBTYXQsIEFwciAw MiwgMjAyMiBhdCAwOTozNzoxN0FNICswODAwLCBBbmR5IFlhbiB3cm90ZToKPj4gSGkgU2FjaGE6 Cj4+Cj4+IE9uIDQvMS8yMiAyMDo1MiwgU2FzY2hhIEhhdWVyIHdyb3RlOgo+Pj4gLS0gCj4+PiA+ RnJvbSBjYmMwMzA3MzYyM2E3MTgwMjQzMzMxYWMyNGMzYWZhZjlkZWM3NTIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQo+Pj4gRnJvbTogU2FzY2hhIEhhdWVyPHMuaGF1ZXJAcGVuZ3V0cm9uaXgu ZGU+Cj4+PiBEYXRlOiBGcmksIDEgQXByIDIwMjIgMTQ6NDg6NDkgKzAyMDAKPj4+IFN1YmplY3Q6 IFtQQVRDSF0gZml4dXAhIGRybTogcm9ja2NoaXA6IEFkZCBWT1AyIGRyaXZlcgo+Pj4KPj4+IC0t LQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AyLmMgfCAx NCArKysrKysrKysrKysrKwo+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKykK Pj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2Ry bV92b3AyLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcDIuYwo+ Pj4gaW5kZXggN2RiYTdiOWI2M2RjNi4uMTQyMWJmMmYxMzNmMSAxMDA2NDQKPj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wMi5jCj4+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcDIuYwo+Pj4gQEAgLTIyODcsNiAr MjI4NywyMCBAQCBzdGF0aWMgaW50IHZvcDJfY3JlYXRlX2NydGMoc3RydWN0IHZvcDIgKnZvcDIp Cj4+PiAgICAJCQl9Cj4+PiAgICAJCX0KPj4+ICsJCWlmICh2b3AyLT5kYXRhLT5zb2NfaWQgPT0g MzU2Nikgewo+Pj4gKwkJCS8qCj4+PiArCQkJICogT24gUkszNTY2IHRoZXNlIHdpbmRvd3MgZG9u J3QgaGF2ZSBhbiBpbmRlcGVuZGVudAo+Pj4gKwkJCSAqIGZyYW1lYnVmZmVyLiBUaGV5IHNoYXJl IHRoZSBmcmFtZWJ1ZmZlciB3aXRoIHNtYXJ0MCwKPj4+ICsJCQkgKiBlc21hcnQwIGFuZCBjbHVz dGVyMCByZXNwZWN0aXZlbHkuCj4+PiArCQkJICovCj4+PiArCQkJc3dpdGNoICh3aW4tPmRhdGEt PnBoeXNfaWQpIHsKPj4+ICsJCQljYXNlIFJPQ0tDSElQX1ZPUDJfU01BUlQxOgo+Pj4gKwkJCWNh c2UgUk9DS0NISVBfVk9QMl9FU01BUlQxOgo+Pj4gKwkJCWNhc2UgUk9DS0NISVBfVk9QMl9DTFVT VEVSMToKPj4+ICsJCQkJY29udGludWU7Cj4+PiArCQkJfQo+Pgo+PiBUaGluayBhYm91dCB0aGlz ICwgdGhlcmUgbWF5YmUgb3RoZXIgdXBjb21pbmcgdm9wMiBiYXNlIHNvYywgdGhleSBtYXkgb25s eQo+PiBoYXZlCj4+Cj4+IG1pcnJvciB3aW5kb3cgU21hcnQxIEVzbWFydDEsIG9yIFNtYXJ0MSwg RXNtYXJ0MSwgRXNtYXJ0MiwgQ2x1c3RlcjEuCj4+Cj4+IEkgdGhpbmsgdGhpcyBzaG91bGQgYWRk IFdJTl9GRUFUVVJFIGF0IHRoZSBwbGF0Zm9ybSBkZXNjcmlwdGlvbiBmaWxlCj4+IHJvY2tjaGlw X3ZvcDJfcmVnLmMsIHRoZW4KPj4KPj4gY2hlY2sgdGhlIEZFQVRVUkUgdG8gZGVjaWRlIHdoZXRo ZXIgdGhlIGRyaXZlciBzaG91bGQgZ2l2ZSB0aGlzIHdpbmRvdyBhCj4+IHNwZWNpYWwgdHJlYXRt ZW50Lgo+Pgo+PiB0aGlzIGNhbiBtYWtlIG9uZSBjb2RlIHJ1biBmb3IgZGlmZmVyZW50IHNvYyB3 aXRoIGRpZmZlcmVudCBwbGF0Zm9ybQo+PiBkZXNjcmlwdGlvbi4gb3Igd2Ugc2hvdWxkIGFkZAo+ Pgo+PiB0aGUgc2FtZSBjb2RlIGxvZ2ljIGZvciBkaWZmZXJlbnQgc29jIGFnYWluIGFuZCBhZ2Fp bi4KPiBZb3UgbWVhbiBsaWtlIGRvbmUgaW4gdGhlIGRvd25zdHJlYW0gS2VybmVsPyBIZXJlIGlu ZGVlZCB3ZSBoYXZlIGEKPiBXSU5fRkVBVFVSRV9NSVJST1IgZmxhZyBhZGRlZCB0byB0aGUgcGxh dGZvcm0gZGVzY3JpcHRpb24uIFRoaXMgaXMgdGhlbgo+IGV2YWx1YXRlZCB3aXRoOgo+Cj4gc3Rh dGljIGJvb2wgdm9wMl9pc19taXJyb3Jfd2luKHN0cnVjdCB2b3AyX3dpbiAqd2luKQo+IHsKPiAg ICAgICAgICByZXR1cm4gc29jX2lzX3JrMzU2NigpICYmICh3aW4tPmZlYXR1cmUgJiBXSU5fRkVB VFVSRV9NSVJST1IpOwo+IH0KPgo+IFNvIGEgZmxhZyBpcyBhZGRlZCBhbmQgYWZ0ZXJ3YXJkcyBp dHMgZXZhbHVhdGlvbiBpcyBTb0Mgc3BlY2lmaWMuIFRoYXQKPiBkb2Vzbid0IGhlbHAgYXQgYWxs IGFuZCBvbmx5IG9iZnVzY2F0ZXMgdGhpbmdzLgo+Cj4gQmVzaWRlcywgZXhwZXJpZW5jZSBzaG93 cyB0aGF0IHlvdSBjYW4ndCBwcmVkaWN0IGEgZ29vZCBhYnN0cmFjdGlvbiBmb3IKClRoaXMgaXMg bm90IGHCoCBwcmVkaWN0LMKgIHRoaXMgaXMgYW4gSVAgZmVhdHVyZSwgc28gaXQgd2lsbCBhcHBl YXJlZCBvbiAKdXBjb21pbmcgU09DLgoKV2UgaGF2ZSByazM1ODggd2l0aCA4IHdpbmRvd3MoNCBD bHVzdGVyICsgNCBFc21hcnQsIG5vIFNtYXJ0IHdpbmRvdyksIGFuZAoKYWxzbyBoYXZlIGEgZW50 cnkgbGV2ZWwgc29jIHdoaWNoIG9ubHkgaGF2ZSA0IHdpbmRvd3MsIHRoZXkgYm90aCBoYXZlIAp0 aGlzIGZlYXR1cmUuCgo+IGZ1dHVyZSBoYXJkd2FyZSByZXZpc2lvbnMsIHRoZSBoYXJkd2FyZSBn dXlzIGFyZSBqdXN0IHRvbyBjcmVhdGl2ZSBpbgo+IGNyZWF0aW5nIGhhcmR3YXJlIHRoYXQgYnJl YWtzIGV4aXN0aW5nIGFic3RyYWN0aW9ucy4KPgo+IFNhc2NoYQo+CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1yb2NrY2hpcCBtYWlsaW5nIGxp c3QKTGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFk ZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXJvY2tjaGlwCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 453F1C433FE for ; Wed, 6 Apr 2022 02:03:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3759A10EB71; Wed, 6 Apr 2022 02:03:04 +0000 (UTC) Received: from mail-m17637.qiye.163.com (mail-m17637.qiye.163.com [59.111.176.37]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3A92010EB83 for ; Wed, 6 Apr 2022 02:03:02 +0000 (UTC) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id F0DA798048A; Wed, 6 Apr 2022 10:02:59 +0800 (CST) Message-ID: <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> Date: Wed, 6 Apr 2022 10:02:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220405093700.GQ4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlIGEtWGE1LSkpOGB oYSkhIVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MRA6GCo5Aj4MHUsIMBYxFThK NDYwCjNVSlVKTU9CSUpLTkNLTUxIVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTklNSjcG X-HM-Tid: 0a7ffc9c5db9d992kuwsf0da798048a X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , Benjamin Gaignard , Piotr Oniszczuk , Sandy Huang , dri-devel@lists.freedesktop.org, "open list:ARM/Rockchip SoC..." , Michael Riesch , kernel@pengutronix.de, Peter Geis , "linux-arm-kernel@lists.infradead.org" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi: On 4/5/22 17:37, Sascha Hauer wrote: > On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote: >> Hi Sacha: >> >> On 4/1/22 20:52, Sascha Hauer wrote: >>> -- >>> >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 >>> From: Sascha Hauer >>> Date: Fri, 1 Apr 2022 14:48:49 +0200 >>> Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver >>> >>> --- >>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>> index 7dba7b9b63dc6..1421bf2f133f1 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>> @@ -2287,6 +2287,20 @@ static int vop2_create_crtc(struct vop2 *vop2) >>> } >>> } >>> + if (vop2->data->soc_id == 3566) { >>> + /* >>> + * On RK3566 these windows don't have an independent >>> + * framebuffer. They share the framebuffer with smart0, >>> + * esmart0 and cluster0 respectively. >>> + */ >>> + switch (win->data->phys_id) { >>> + case ROCKCHIP_VOP2_SMART1: >>> + case ROCKCHIP_VOP2_ESMART1: >>> + case ROCKCHIP_VOP2_CLUSTER1: >>> + continue; >>> + } >> >> Think about this , there maybe other upcoming vop2 base soc, they may only >> have >> >> mirror window Smart1 Esmart1, or Smart1, Esmart1, Esmart2, Cluster1. >> >> I think this should add WIN_FEATURE at the platform description file >> rockchip_vop2_reg.c, then >> >> check the FEATURE to decide whether the driver should give this window a >> special treatment. >> >> this can make one code run for different soc with different platform >> description. or we should add >> >> the same code logic for different soc again and again. > You mean like done in the downstream Kernel? Here indeed we have a > WIN_FEATURE_MIRROR flag added to the platform description. This is then > evaluated with: > > static bool vop2_is_mirror_win(struct vop2_win *win) > { > return soc_is_rk3566() && (win->feature & WIN_FEATURE_MIRROR); > } > > So a flag is added and afterwards its evaluation is SoC specific. That > doesn't help at all and only obfuscates things. > > Besides, experience shows that you can't predict a good abstraction for This is not a  predict,  this is an IP feature, so it will appeared on upcoming SOC. We have rk3588 with 8 windows(4 Cluster + 4 Esmart, no Smart window), and also have a entry level soc which only have 4 windows, they both have this feature. > future hardware revisions, the hardware guys are just too creative in > creating hardware that breaks existing abstractions. > > Sascha > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC15FC433EF for ; Wed, 6 Apr 2022 02:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JZaiiaZYT1JtdWLpYxuEaJRBFpucUizPgroM5CvbMWI=; b=P6cnqNSKh+231I gvx3rJz2a3awgLauYtmGfNYFgKMtHVzVHgCzhj+GAnhnybiTmTX4bmT0KXXthdsmzPVl5u4MKdTJg zyZwdKKCOd0wyUaqqpmUvG4S/02xhk2WIMJQ0O4TEMXaO+YrJCzgNPhmHMsXC9OEV+19JDY6qoumZ 9hMMEeQSKWB3ZRh9xsUnnN7udmb5XG7uHnUHK/gdkT0OPyxVl0TrVL7P2AmLf6momX5FSweP9OCQV MGWdCmpZrt3JDQ2Yjd6Lvpq6DuEP3C1Z/qfd+zEZxa/64AE6jWZ5SO1nOLNGQoW64JRQfO29b3xCQ xFOrirzoo8PtFv+lOfIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbv0l-003Jrh-RV; Wed, 06 Apr 2022 02:03:07 +0000 Received: from mail-m17637.qiye.163.com ([59.111.176.37]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbv0h-003Jq0-Sj; Wed, 06 Apr 2022 02:03:05 +0000 Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id F0DA798048A; Wed, 6 Apr 2022 10:02:59 +0800 (CST) Message-ID: <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> Date: Wed, 6 Apr 2022 10:02:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer Cc: Piotr Oniszczuk , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220405093700.GQ4012@pengutronix.de> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlIGEtWGE1LSkpOGB oYSkhIVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MRA6GCo5Aj4MHUsIMBYxFThK NDYwCjNVSlVKTU9CSUpLTkNLTUxIVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTklNSjcG X-HM-Tid: 0a7ffc9c5db9d992kuwsf0da798048a X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220405_190304_138314_327E1A59 X-CRM114-Status: GOOD ( 22.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGk6CgpPbiA0LzUvMjIgMTc6MzcsIFNhc2NoYSBIYXVlciB3cm90ZToKPiBPbiBTYXQsIEFwciAw MiwgMjAyMiBhdCAwOTozNzoxN0FNICswODAwLCBBbmR5IFlhbiB3cm90ZToKPj4gSGkgU2FjaGE6 Cj4+Cj4+IE9uIDQvMS8yMiAyMDo1MiwgU2FzY2hhIEhhdWVyIHdyb3RlOgo+Pj4gLS0gCj4+PiA+ RnJvbSBjYmMwMzA3MzYyM2E3MTgwMjQzMzMxYWMyNGMzYWZhZjlkZWM3NTIyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQo+Pj4gRnJvbTogU2FzY2hhIEhhdWVyPHMuaGF1ZXJAcGVuZ3V0cm9uaXgu ZGU+Cj4+PiBEYXRlOiBGcmksIDEgQXByIDIwMjIgMTQ6NDg6NDkgKzAyMDAKPj4+IFN1YmplY3Q6 IFtQQVRDSF0gZml4dXAhIGRybTogcm9ja2NoaXA6IEFkZCBWT1AyIGRyaXZlcgo+Pj4KPj4+IC0t LQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AyLmMgfCAx NCArKysrKysrKysrKysrKwo+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKykK Pj4+Cj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2Ry bV92b3AyLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcDIuYwo+ Pj4gaW5kZXggN2RiYTdiOWI2M2RjNi4uMTQyMWJmMmYxMzNmMSAxMDA2NDQKPj4+IC0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wMi5jCj4+PiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcDIuYwo+Pj4gQEAgLTIyODcsNiAr MjI4NywyMCBAQCBzdGF0aWMgaW50IHZvcDJfY3JlYXRlX2NydGMoc3RydWN0IHZvcDIgKnZvcDIp Cj4+PiAgICAJCQl9Cj4+PiAgICAJCX0KPj4+ICsJCWlmICh2b3AyLT5kYXRhLT5zb2NfaWQgPT0g MzU2Nikgewo+Pj4gKwkJCS8qCj4+PiArCQkJICogT24gUkszNTY2IHRoZXNlIHdpbmRvd3MgZG9u J3QgaGF2ZSBhbiBpbmRlcGVuZGVudAo+Pj4gKwkJCSAqIGZyYW1lYnVmZmVyLiBUaGV5IHNoYXJl IHRoZSBmcmFtZWJ1ZmZlciB3aXRoIHNtYXJ0MCwKPj4+ICsJCQkgKiBlc21hcnQwIGFuZCBjbHVz dGVyMCByZXNwZWN0aXZlbHkuCj4+PiArCQkJICovCj4+PiArCQkJc3dpdGNoICh3aW4tPmRhdGEt PnBoeXNfaWQpIHsKPj4+ICsJCQljYXNlIFJPQ0tDSElQX1ZPUDJfU01BUlQxOgo+Pj4gKwkJCWNh c2UgUk9DS0NISVBfVk9QMl9FU01BUlQxOgo+Pj4gKwkJCWNhc2UgUk9DS0NISVBfVk9QMl9DTFVT VEVSMToKPj4+ICsJCQkJY29udGludWU7Cj4+PiArCQkJfQo+Pgo+PiBUaGluayBhYm91dCB0aGlz ICwgdGhlcmUgbWF5YmUgb3RoZXIgdXBjb21pbmcgdm9wMiBiYXNlIHNvYywgdGhleSBtYXkgb25s eQo+PiBoYXZlCj4+Cj4+IG1pcnJvciB3aW5kb3cgU21hcnQxIEVzbWFydDEsIG9yIFNtYXJ0MSwg RXNtYXJ0MSwgRXNtYXJ0MiwgQ2x1c3RlcjEuCj4+Cj4+IEkgdGhpbmsgdGhpcyBzaG91bGQgYWRk IFdJTl9GRUFUVVJFIGF0IHRoZSBwbGF0Zm9ybSBkZXNjcmlwdGlvbiBmaWxlCj4+IHJvY2tjaGlw X3ZvcDJfcmVnLmMsIHRoZW4KPj4KPj4gY2hlY2sgdGhlIEZFQVRVUkUgdG8gZGVjaWRlIHdoZXRo ZXIgdGhlIGRyaXZlciBzaG91bGQgZ2l2ZSB0aGlzIHdpbmRvdyBhCj4+IHNwZWNpYWwgdHJlYXRt ZW50Lgo+Pgo+PiB0aGlzIGNhbiBtYWtlIG9uZSBjb2RlIHJ1biBmb3IgZGlmZmVyZW50IHNvYyB3 aXRoIGRpZmZlcmVudCBwbGF0Zm9ybQo+PiBkZXNjcmlwdGlvbi4gb3Igd2Ugc2hvdWxkIGFkZAo+ Pgo+PiB0aGUgc2FtZSBjb2RlIGxvZ2ljIGZvciBkaWZmZXJlbnQgc29jIGFnYWluIGFuZCBhZ2Fp bi4KPiBZb3UgbWVhbiBsaWtlIGRvbmUgaW4gdGhlIGRvd25zdHJlYW0gS2VybmVsPyBIZXJlIGlu ZGVlZCB3ZSBoYXZlIGEKPiBXSU5fRkVBVFVSRV9NSVJST1IgZmxhZyBhZGRlZCB0byB0aGUgcGxh dGZvcm0gZGVzY3JpcHRpb24uIFRoaXMgaXMgdGhlbgo+IGV2YWx1YXRlZCB3aXRoOgo+Cj4gc3Rh dGljIGJvb2wgdm9wMl9pc19taXJyb3Jfd2luKHN0cnVjdCB2b3AyX3dpbiAqd2luKQo+IHsKPiAg ICAgICAgICByZXR1cm4gc29jX2lzX3JrMzU2NigpICYmICh3aW4tPmZlYXR1cmUgJiBXSU5fRkVB VFVSRV9NSVJST1IpOwo+IH0KPgo+IFNvIGEgZmxhZyBpcyBhZGRlZCBhbmQgYWZ0ZXJ3YXJkcyBp dHMgZXZhbHVhdGlvbiBpcyBTb0Mgc3BlY2lmaWMuIFRoYXQKPiBkb2Vzbid0IGhlbHAgYXQgYWxs IGFuZCBvbmx5IG9iZnVzY2F0ZXMgdGhpbmdzLgo+Cj4gQmVzaWRlcywgZXhwZXJpZW5jZSBzaG93 cyB0aGF0IHlvdSBjYW4ndCBwcmVkaWN0IGEgZ29vZCBhYnN0cmFjdGlvbiBmb3IKClRoaXMgaXMg bm90IGHCoCBwcmVkaWN0LMKgIHRoaXMgaXMgYW4gSVAgZmVhdHVyZSwgc28gaXQgd2lsbCBhcHBl YXJlZCBvbiAKdXBjb21pbmcgU09DLgoKV2UgaGF2ZSByazM1ODggd2l0aCA4IHdpbmRvd3MoNCBD bHVzdGVyICsgNCBFc21hcnQsIG5vIFNtYXJ0IHdpbmRvdyksIGFuZAoKYWxzbyBoYXZlIGEgZW50 cnkgbGV2ZWwgc29jIHdoaWNoIG9ubHkgaGF2ZSA0IHdpbmRvd3MsIHRoZXkgYm90aCBoYXZlIAp0 aGlzIGZlYXR1cmUuCgo+IGZ1dHVyZSBoYXJkd2FyZSByZXZpc2lvbnMsIHRoZSBoYXJkd2FyZSBn dXlzIGFyZSBqdXN0IHRvbyBjcmVhdGl2ZSBpbgo+IGNyZWF0aW5nIGhhcmR3YXJlIHRoYXQgYnJl YWtzIGV4aXN0aW5nIGFic3RyYWN0aW9ucy4KPgo+IFNhc2NoYQo+CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcg bGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDD3CC433EF for ; Wed, 6 Apr 2022 16:27:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237637AbiDFQ32 (ORCPT ); Wed, 6 Apr 2022 12:29:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237748AbiDFQ2t (ORCPT ); Wed, 6 Apr 2022 12:28:49 -0400 Received: from mail-m17637.qiye.163.com (mail-m17637.qiye.163.com [59.111.176.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 215B82016B7 for ; Tue, 5 Apr 2022 19:03:02 -0700 (PDT) Received: from [172.16.12.141] (unknown [58.22.7.114]) by mail-m17637.qiye.163.com (Hmail) with ESMTPA id F0DA798048A; Wed, 6 Apr 2022 10:02:59 +0800 (CST) Message-ID: <12a8c0ef-90ee-cf7e-50a0-e00add8af147@rock-chips.com> Date: Wed, 6 Apr 2022 10:02:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v9 00/23] drm/rockchip: RK356x VOP2 support Content-Language: en-US To: Sascha Hauer Cc: Piotr Oniszczuk , dri-devel@lists.freedesktop.org, "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "devicetree@vger.kernel.org" , kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Peter Geis References: <20220328151116.2034635-1-s.hauer@pengutronix.de> <20220401125205.GL4012@pengutronix.de> <1c0fbf4f-2e17-29f9-5c69-c80b53ff3d2f@rock-chips.com> <20220405093700.GQ4012@pengutronix.de> From: Andy Yan In-Reply-To: <20220405093700.GQ4012@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgPGg8OCBgUHx5ZQUlOS1dZCBgUCR5ZQVlLVUtZV1 kWDxoPAgseWUFZKDYvK1lXWShZQUlKS0tKN1dZLVlBSVdZDwkaFQgSH1lBWRlIGEtWGE1LSkpOGB oYSkhIVRMBExYaEhckFA4PWVdZFhoPEhUdFFlBWU9LSFVKSktISkNVS1kG X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6MRA6GCo5Aj4MHUsIMBYxFThK NDYwCjNVSlVKTU9CSUpLTkNLTUxIVTMWGhIXVRoVHwJVAhoVOwkUGBBWGBMSCwhVGBQWRVlXWRIL WUFZTkNVSUlVTFVKSk9ZV1kIAVlBTklNSjcG X-HM-Tid: 0a7ffc9c5db9d992kuwsf0da798048a Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi: On 4/5/22 17:37, Sascha Hauer wrote: > On Sat, Apr 02, 2022 at 09:37:17AM +0800, Andy Yan wrote: >> Hi Sacha: >> >> On 4/1/22 20:52, Sascha Hauer wrote: >>> -- >>> >From cbc03073623a7180243331ac24c3afaf9dec7522 Mon Sep 17 00:00:00 2001 >>> From: Sascha Hauer >>> Date: Fri, 1 Apr 2022 14:48:49 +0200 >>> Subject: [PATCH] fixup! drm: rockchip: Add VOP2 driver >>> >>> --- >>> drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>> index 7dba7b9b63dc6..1421bf2f133f1 100644 >>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c >>> @@ -2287,6 +2287,20 @@ static int vop2_create_crtc(struct vop2 *vop2) >>> } >>> } >>> + if (vop2->data->soc_id == 3566) { >>> + /* >>> + * On RK3566 these windows don't have an independent >>> + * framebuffer. They share the framebuffer with smart0, >>> + * esmart0 and cluster0 respectively. >>> + */ >>> + switch (win->data->phys_id) { >>> + case ROCKCHIP_VOP2_SMART1: >>> + case ROCKCHIP_VOP2_ESMART1: >>> + case ROCKCHIP_VOP2_CLUSTER1: >>> + continue; >>> + } >> >> Think about this , there maybe other upcoming vop2 base soc, they may only >> have >> >> mirror window Smart1 Esmart1, or Smart1, Esmart1, Esmart2, Cluster1. >> >> I think this should add WIN_FEATURE at the platform description file >> rockchip_vop2_reg.c, then >> >> check the FEATURE to decide whether the driver should give this window a >> special treatment. >> >> this can make one code run for different soc with different platform >> description. or we should add >> >> the same code logic for different soc again and again. > You mean like done in the downstream Kernel? Here indeed we have a > WIN_FEATURE_MIRROR flag added to the platform description. This is then > evaluated with: > > static bool vop2_is_mirror_win(struct vop2_win *win) > { > return soc_is_rk3566() && (win->feature & WIN_FEATURE_MIRROR); > } > > So a flag is added and afterwards its evaluation is SoC specific. That > doesn't help at all and only obfuscates things. > > Besides, experience shows that you can't predict a good abstraction for This is not a  predict,  this is an IP feature, so it will appeared on upcoming SOC. We have rk3588 with 8 windows(4 Cluster + 4 Esmart, no Smart window), and also have a entry level soc which only have 4 windows, they both have this feature. > future hardware revisions, the hardware guys are just too creative in > creating hardware that breaks existing abstractions. > > Sascha >