From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE7C7C4320E for ; Thu, 2 Sep 2021 10:16:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 62FE661090 for ; Thu, 2 Sep 2021 10:16:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 62FE661090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:41528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLjm2-0001XI-9y for qemu-devel@archiver.kernel.org; Thu, 02 Sep 2021 06:16:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLjko-0000lG-UN for qemu-devel@nongnu.org; Thu, 02 Sep 2021 06:15:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43155) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLjkk-0003l7-OL for qemu-devel@nongnu.org; Thu, 02 Sep 2021 06:15:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630577725; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7yWdV0plLO1YZjtoutIF8NJosUU62bDCi+AWXM1wHR0=; b=bIiP7Os5CZH//tXV8OSkRRB8VUHyCOgvxCQEEBDe8z+xYHUdznTFBKOcTJs3U3jgcdrInr folwzWsNy4xe7mxsE14ZACXPzZ7n3mSWvkaaVPevb/E4Sa0bd4iDxZ1PyPJnQrMnAqNnQr w/Q1uJDGr8OMMsZHGZ4E3JKMLfuzhXE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-508-cq8_nwXvMvKRStD3Ri7MBg-1; Thu, 02 Sep 2021 06:15:24 -0400 X-MC-Unique: cq8_nwXvMvKRStD3Ri7MBg-1 Received: by mail-wm1-f69.google.com with SMTP id r125-20020a1c2b830000b0290197a4be97b7so506216wmr.9 for ; Thu, 02 Sep 2021 03:15:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7yWdV0plLO1YZjtoutIF8NJosUU62bDCi+AWXM1wHR0=; b=g6T+QSg1IB4jrqKg/y9y2axs9WvOSdccVuym5bk2PnT2blT1EuC3K3waJXttYFkeRn /4hf+QiHI85YvepNHxlRKWDhUKaA6sP4/Y40u4xV6C8bdzqvy4/XaJWg5bbHlPmxsmpo +MrFpquP4dUP2fL5IjUTIg1CPTX5LH3GR0iUpw12bGAxoPXWjUor7m1jYkaJ3a5q9QbY 2fT71tGJ9D+cVj9O5r+58lL3fkFl1uYNTS+2evmb8kYIBaCOt/akV9jzhkL2ByI3Sncr efrrlODpFlhdbydRXqyaeDlBKCIQ25BdAEGyw84GsqVRS40VqoUMS033pT56WTy796iS 5bJg== X-Gm-Message-State: AOAM530UIO/jsfPMNyTVG7wzgDZVchUT6HBZtF0BMOaO//Gkyuy/QxEp mxNpbY3cr2Pl2TiZS5V1Be+utPzxKzcU0D/oAEM/qlQPsTOQAd1wjARPIepSji+tWDR3t+FtT18 hW4ci7HXMkzkns9E= X-Received: by 2002:adf:a2c4:: with SMTP id t4mr2773718wra.258.1630577723094; Thu, 02 Sep 2021 03:15:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyc8J4YcLsSWsPc5+lA8VmCGxZ6LQX090cLFU/82RgtjKyLElxtHy2uzOgj4uQTQgMi2aBVVA== X-Received: by 2002:adf:a2c4:: with SMTP id t4mr2773681wra.258.1630577722777; Thu, 02 Sep 2021 03:15:22 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id o21sm1383684wms.32.2021.09.02.03.15.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 03:15:22 -0700 (PDT) Subject: Re: [PATCH v4 4/5] mirror-top-perms: Fix AbnormalShutdown path To: Vladimir Sementsov-Ogievskiy , Hanna Reitz , qemu-block@nongnu.org, Cleber Rosa , Willian Rampazzo References: <20210902094017.32902-1-hreitz@redhat.com> <20210902094017.32902-5-hreitz@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <12a9bfd7-d302-f157-f88a-ff441470278e@redhat.com> Date: Thu, 2 Sep 2021 12:15:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.029, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , John Snow , qemu-devel@nongnu.org, Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/2/21 11:58 AM, Vladimir Sementsov-Ogievskiy wrote: > 02.09.2021 12:40, Hanna Reitz wrote: >> The AbnormalShutdown exception class is not in qemu.machine, but in >> qemu.machine.machine.  (qemu.machine.AbnormalShutdown was enough for >> Python to find it in order to run this test, but pylint complains about >> it.) >> >> Signed-off-by: Hanna Reitz >> --- >>   tests/qemu-iotests/tests/mirror-top-perms | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/qemu-iotests/tests/mirror-top-perms >> b/tests/qemu-iotests/tests/mirror-top-perms >> index 451a0666f8..2fc8dd66e0 100755 >> --- a/tests/qemu-iotests/tests/mirror-top-perms >> +++ b/tests/qemu-iotests/tests/mirror-top-perms >> @@ -47,7 +47,7 @@ class TestMirrorTopPerms(iotests.QMPTestCase): >>       def tearDown(self): >>           try: >>               self.vm.shutdown() >> -        except qemu.machine.AbnormalShutdown: >> +        except qemu.machine.machine.AbnormalShutdown: >>               pass >>             if self.vm_b is not None: >> > > Hmm, interesting.. May be that bad that module has same name as subpackage? Confusing indeed. Could this be improved?