All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Maciej S. Szmigiero" <maciej.szmigiero@oracle.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Jon Doron <arilou@gmail.com>,
	qemu-devel@nongnu.org, Roman Kagan <rkagan@virtuozzo.com>
Subject: Re: [PATCH] vmbus: Don't make QOM property registration conditional
Date: Sun, 25 Apr 2021 14:21:38 +0200	[thread overview]
Message-ID: <12b52998-d818-5d2a-691b-5bd9135a8042@oracle.com> (raw)
In-Reply-To: <4de9310f-7627-7440-7fcb-23dc2a0f7441@oracle.com>

On 11.10.2020 01:30, Maciej S. Szmigiero wrote:
> On 09.10.2020 23:33, Eduardo Habkost wrote:
>> On Fri, Oct 09, 2020 at 11:05:47PM +0200, Maciej S. Szmigiero wrote:
>>> On 09.10.2020 22:07, Eduardo Habkost wrote:
>>>> Having properties registered conditionally makes QOM type
>>>> introspection difficult.  Instead of skipping registration of the
>>>> "instanceid" property, always register the property but validate
>>>> its value against the instance id required by the class.
>>>>
>>>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>>>> ---
>>>> Note: due to the lack of concrete vmbus-dev subclasses in the
>>>> QEMU tree, this patch couldn't be tested.
>>>
>>> Will test it tomorrow since I have a VMBus device implementation.
>>
>> Thanks!
>>
> 
> Tested the patch with a hv-balloon device and is seems to work okay, so:
> Acked-by: Maciej S. Szmigiero <maciej.szmigiero@oracle.com>
> 

I see this patch wasn't picked up - it still makes sense and applies
cleanly to the current git, so I think it should be picked up.

Thanks,
Maciej


  reply	other threads:[~2021-04-25 12:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-09 20:07 [PATCH] vmbus: Don't make QOM property registration conditional Eduardo Habkost
2020-10-09 21:05 ` Maciej S. Szmigiero
2020-10-09 21:33   ` Eduardo Habkost
2020-10-10 23:30     ` Maciej S. Szmigiero
2021-04-25 12:21       ` Maciej S. Szmigiero [this message]
2021-04-27 20:45         ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12b52998-d818-5d2a-691b-5bd9135a8042@oracle.com \
    --to=maciej.szmigiero@oracle.com \
    --cc=arilou@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkagan@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.