From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwFVo-0007co-Vh for qemu-devel@nongnu.org; Mon, 17 Oct 2016 17:32:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwFVl-0006SM-4t for qemu-devel@nongnu.org; Mon, 17 Oct 2016 17:32:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49206) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1bwFVk-0006RW-Tw for qemu-devel@nongnu.org; Mon, 17 Oct 2016 17:31:57 -0400 References: <1473390856-4502-1-git-send-email-eblake@redhat.com> <1473390856-4502-3-git-send-email-eblake@redhat.com> From: Eric Blake Message-ID: <12c8810b-5ecd-537a-9f47-5f518646c79f@redhat.com> Date: Mon, 17 Oct 2016 16:31:54 -0500 MIME-Version: 1.0 In-Reply-To: <1473390856-4502-3-git-send-email-eblake@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dkvrhqXaequ5nosIdeltOK6eFHkwC9S1d" Subject: Re: [Qemu-devel] [PATCH 2/3] migrate: Share common MigrationParameters struct List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , Luiz Capitulino , Markus Armbruster , ashijeetacharya@gmail.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dkvrhqXaequ5nosIdeltOK6eFHkwC9S1d From: Eric Blake To: qemu-devel@nongnu.org Cc: Amit Shah , Luiz Capitulino , Markus Armbruster , ashijeetacharya@gmail.com, quintela@redhat.com Message-ID: <12c8810b-5ecd-537a-9f47-5f518646c79f@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/3] migrate: Share common MigrationParameters struct References: <1473390856-4502-1-git-send-email-eblake@redhat.com> <1473390856-4502-3-git-send-email-eblake@redhat.com> In-Reply-To: <1473390856-4502-3-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/08/2016 10:14 PM, Eric Blake wrote: > It is rather verbose, and slightly error-prone, to repeat > the same set of parameters for input (migrate-set-parameters) > as for output (query-migrate-parameters), where the only > difference is whether the members are optional. We can just > document that the optional members will always be present > on output, and then share a common struct between both > commands. The next patch can then reduce the amount of > code needed on input. > '*tls-hostname': 'str'} } > - > -# > -# @MigrationParameters > -# =2E.. > -## > -{ 'struct': 'MigrationParameters', > - 'data': { 'compress-level': 'int', > - 'compress-threads': 'int', > - 'decompress-threads': 'int', > - 'cpu-throttle-initial': 'int', > - 'cpu-throttle-increment': 'int', > - 'tls-creds': 'str', > - 'tls-hostname': 'str'} } > ## > # @query-migrate-parameters Pre-existing - there was no blank line before the docs for query-migrate-parameters. Commit a43edcf fixed the blank line, then the merge conflict resolution undid things; so I've submitted a followup. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dkvrhqXaequ5nosIdeltOK6eFHkwC9S1d Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJYBUNKAAoJEKeha0olJ0Nq5sMIAIm6aletWbvrBUn5US+sWZzC RanE22n1uxQQdtb5OclEJssuwKEQQ89+IDm/XsGmekA3AXRh/jnzqjHp6ZBEG368 cYtVD/cjWtgWqibCXim5M6OfAFJsvdPx32BrKnkCE+lNUYcsRNLBWa7g4jJmcSSc P/ewzSWgEd7Oe9HxX5UKXPnkMCc4DTt9F1H6GYb8o8MLf6gzRPNt5PVXSb0tfc05 RWyGxyZ0zOpH2ESqu+uLghoE09rP9JsdDGPqRmEYKF9IZN9KX01OUHT9ppvd6Hi+ mE8UrKyoSXiCoQ1vsvbH3MEKPh6K0R7lS2nfS3rwuHn7yaXPUhSn2MJUANoRTvs= =8C1H -----END PGP SIGNATURE----- --dkvrhqXaequ5nosIdeltOK6eFHkwC9S1d--