All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Riku Voipio <riku.voipio@iki.fi>, Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2 7/9] linux-user: Split linux-user internals out of qemu.h
Date: Sun, 12 Sep 2021 09:28:07 -0700	[thread overview]
Message-ID: <12d3f905-864c-30eb-e274-e3f37c5c1b27@linaro.org> (raw)
In-Reply-To: <20210908154405.15417-8-peter.maydell@linaro.org>

On 9/8/21 8:44 AM, Peter Maydell wrote:
> qemu.h is included in various non-linux-user files (which
> mostly want the TaskState struct and the functions for
> doing usermode access to guest addresses like lock_user(),
> unlock_user(), get_user*(), etc).
> 
> Split out the parts that are only used in linux-user itself
> into a new user-internals.h. This leaves qemu.h with basically
> three things:
>   * the definition of the TaskState struct
>   * the user-access functions and macros
>   * do_brk()
> all of which are needed by code outside linux-user that
> includes qemu.h.
> 
> The addition of all the extra #include lines was done with
>    sed -i '/include.*qemu\.h/a #include "user-internals.h"' $(git grep -l 'include.*qemu\.h' linux-user)
> (and then undoing the change to fpa11.h).
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2021-09-12 16:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-08 15:43 [PATCH v2 0/9] linux-user: split internals out of qemu.h Peter Maydell
2021-09-08 15:43 ` [PATCH v2 1/9] linux-user: Fix coding style nits in qemu.h Peter Maydell
2021-09-12 16:07   ` Richard Henderson
2021-09-08 15:43 ` [PATCH v2 2/9] linux-user: Split strace prototypes into strace.h Peter Maydell
2021-09-12 16:16   ` Richard Henderson
2021-09-08 15:43 ` [PATCH v2 3/9] linux-user: Split signal-related prototypes into signal-common.h Peter Maydell
2021-09-08 15:59   ` Philippe Mathieu-Daudé
2021-09-12 16:16   ` Richard Henderson
2021-09-08 15:44 ` [PATCH v2 4/9] linux-user: Split loader-related prototypes into loader.h Peter Maydell
2021-09-08 16:00   ` Philippe Mathieu-Daudé
2021-09-12 16:17   ` Richard Henderson
2021-09-08 15:44 ` [PATCH v2 5/9] linux-user: Split mmap prototypes into user-mmap.h Peter Maydell
2021-09-08 16:01   ` Philippe Mathieu-Daudé
2021-09-12 16:18   ` Richard Henderson
2021-09-08 15:44 ` [PATCH v2 6/9] linux-user: Split safe-syscall macro into its own header Peter Maydell
2021-09-12 16:23   ` Richard Henderson
2021-09-13  8:20     ` Peter Maydell
2021-09-08 15:44 ` [PATCH v2 7/9] linux-user: Split linux-user internals out of qemu.h Peter Maydell
2021-09-12 16:28   ` Richard Henderson [this message]
2021-09-08 15:44 ` [PATCH v2 8/9] linux-user: Don't include gdbstub.h in qemu.h Peter Maydell
2021-09-12 16:35   ` Richard Henderson
2021-09-08 15:44 ` [PATCH v2 9/9] linux-user: Drop unneeded includes from qemu.h Peter Maydell
2021-09-12 16:36   ` Richard Henderson
2021-09-13 19:07 ` [PATCH v2 0/9] linux-user: split internals out of qemu.h Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12d3f905-864c-30eb-e274-e3f37c5c1b27@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=laurent@vivier.eu \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.