All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <kernellwp@gmail.com>,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: "Radim Krčmář" <rkrcmar@redhat.com>,
	"Wanpeng Li" <wanpeng.li@hotmail.com>
Subject: Re: [PATCH v8] KVM: LAPIC: Apply change to TDCR right away to the timer
Date: Fri, 6 Oct 2017 16:51:57 +0200	[thread overview]
Message-ID: <12d7651f-868e-aaec-6e91-a53f9819d817@redhat.com> (raw)
In-Reply-To: <1507300712-9317-1-git-send-email-wanpeng.li@hotmail.com>

On 06/10/2017 16:38, Wanpeng Li wrote:
> +	now = ktime_get();
> +	remaining = ktime_sub(apic->lapic_timer.target_expiration, now);

Still need to compare against zero here.  I guess Radim can do it.

Paolo

> +	ns_remaining_old = ktime_to_ns(remaining);
> +	ns_remaining_new = mul_u64_u32_div(ns_remaining_old,
> +                              apic->divide_count, old_divisor);
> +
> +	apic->lapic_timer.tscdeadline += nsec_to_cycles(apic->vcpu, ns_remaining_new) -
> +                                     nsec_to_cycles(apic->vcpu, ns_remaining_old);
> +	apic->lapic_timer.target_expiration = ktime_add_ns(now, ns_remaining_new);

  reply	other threads:[~2017-10-06 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 14:38 [PATCH v8] KVM: LAPIC: Apply change to TDCR right away to the timer Wanpeng Li
2017-10-06 14:51 ` Paolo Bonzini [this message]
2017-10-06 15:02   ` Radim Krčmář
2017-10-06 16:37 ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12d7651f-868e-aaec-6e91-a53f9819d817@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rkrcmar@redhat.com \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.