All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, "Wei Liu" <wl@xen.org>,
	"Jun Nakajima" <jun.nakajima@intel.com>,
	"Kevin Tian" <kevin.tian@intel.com>,
	"Thiner Logoer" <logoerthiner1@163.com>,
	"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
	Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: x86/vmx: Don't spuriously crash the domain when INIT is received
Date: Fri, 25 Feb 2022 09:44:24 +0100	[thread overview]
Message-ID: <12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com> (raw)
In-Reply-To: <20220224194853.17774-3-andrew.cooper3@citrix.com>

On 24.02.2022 20:48, Andrew Cooper wrote:
> In VMX operation, the handling of INIT IPIs is changed.  EXIT_REASON_INIT has
> nothing to do with the guest in question, simply signals that an INIT was
> received.
> 
> Ignoring the INIT is probably the wrong thing to do, but is helpful for
> debugging.  Crashing the domain which happens to be in context is definitely
> wrong.  Print an error message and continue.
> 
> Discovered as collateral damage from when an AP triple faults on S3 resume on
> Intel TigerLake platforms.

I'm afraid I don't follow the scenario, which was (only) outlined in
patch 1: Why would the BSP receive INIT in this case? And it also
cannot be that the INIT was received by the vCPU while running on
another CPU: With APs not coming back up, it cannot have been
scheduled to run there. And it would have been de-scheduled before
suspending (i.e. before any INITs are sent).

Jan



  reply	other threads:[~2022-02-25  8:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-24 19:48 x86: Fix crash on S3 resume Andrew Cooper
2022-02-24 19:48 ` x86/CET: Fix S3 resume with shadow stacks active Andrew Cooper
2022-02-25  8:38   ` Jan Beulich
2022-02-25 12:41     ` Andrew Cooper
2022-02-24 19:48 ` x86/vmx: Don't spuriously crash the domain when INIT is received Andrew Cooper
2022-02-25  8:44   ` Jan Beulich [this message]
2022-02-25 12:28     ` Andrew Cooper
2022-02-25 13:19       ` Jan Beulich
2022-02-25 13:51         ` Marek Marczykowski-Górecki
2022-02-25 14:18           ` Jan Beulich
2022-02-25 17:11         ` Andrew Cooper
2022-02-26 22:55           ` Jason Andryuk
2022-02-28  7:36           ` Jan Beulich
2022-03-14  6:35             ` Tian, Kevin
2022-03-14  7:43               ` Jan Beulich
2022-03-17  5:57                 ` Tian, Kevin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12d8b90b-15b0-c094-71e5-35cfdbfe72b4@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=jun.nakajima@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=logoerthiner1@163.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=roger.pau@citrix.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.