From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754781Ab1CYIBC (ORCPT ); Fri, 25 Mar 2011 04:01:02 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:49207 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752180Ab1CYIBA convert rfc822-to-8bit (ORCPT ); Fri, 25 Mar 2011 04:01:00 -0400 X-Amavis-Alert: BAD HEADER SECTION, Improper folded header field made up entirely of whitespace (char 09 hex): Face: ...MWASAkVVViQjzP\n jycPrvgA\n\t\n R1goSzOnkp14Y[...] Subject: Re: [git pull] drm fixes From: Michel =?ISO-8859-1?Q?D=E4nzer?= To: Dave Airlie Cc: Linus Torvalds , linux-kernel@vger.kernel.org, DRI mailing list In-Reply-To: References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> <1300880747.16522.13.camel@thor.local> <1301039010.12159.56.camel@thor.local> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAAXNSR0IArs4c6QAAADBQTFRFDg4OHh4eLCwsOzs7S0tLWlpaa2treXl5hISEjY2NmJiYqKiotLS0xsbG1dXV/Pz81CO0SQAAArtJREFUOMtd1M9P01AcAHCI/4AtGq/QDfDHRfraEX8eaNeJFw1rO/DCYet7mxc1ZG0x3sStHQkmZpqtHDwAi+tMiFEzbZdwNWEJR48cjPG4g5HhELUbrHvjpYe2n7zvt++977cD/7rjsCry8uNG93Gge9OKUyAAgLB1AlpTZICmAzR15QTEiQAPAKADYLMPfhNnEJR4HvD0tT5YI2KGUcyqihQN7mDwZ3hMN4q2N4ol+gEGTSLWhorrjYXrGPwc0jTDOoKP4xi8G0W6adl2Gz6zGDwag5p5PMON7vZgJuSB976+3U6y2QdeKNet1+uum9/qwVQHvEjtKesY0EIb7CNYe+7DIRXCID/vQ4tksVAY7JFBD7yvqrWTL93xoUmOQsPIddbnuk8v+bBPsigB2KRlFxS4nL/owwEpKBSg2MU3UcDf+nATyyHEQwrHzJZFNpXeuOHDC0qW4sMhEHESFGOUrvgQpWUYFVNQdjQxca8abnSB55CmehdcLSxa1ifoQ4JBpmGYWbhsly3X0fxQ7xmkW3Y5CztLcXI+fAu2oWho3nbV6s5rH35xSC/aBR2tOpVa/Utv25tcTDPL6aT21kG17WrvaFtMBJmFhJCsVF4uu9VG76DWBaRnEiNs7pU659pYlfwtQSRy9GCYlwR7C6/dPQgBw3MsTPNWA4d9SeMDDC9JYdnqq/amdF+diGnVhXFztQ/2lJSWjulOxjRX+uC7EkOqhLRk2ejrqHVBEqCqJLO5cmEXgx8TrBiWVQh1u2DhzQlPsyIveU2YLGorGBxODoR5notlpcUieoLB1/NEmGc4AalGJpLe8WF/8txMWASAkVVViQjzP jycPrvgA R1goSzOnkp14YCYHsp7QJHAS5QcXDqG1jBxdSITVgBNkBTFloj88Q/gMkFcuItYiQPUCBGc2xh5drsD/wGZrgsgDOE4ZAAAAABJRU5ErkJggg== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Date: Fri, 25 Mar 2011 09:00:45 +0100 Message-ID: <1301040045.12159.64.camel@thor.local> Mime-Version: 1.0 X-Mailer: Evolution 2.32.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fre, 2011-03-25 at 17:51 +1000, Dave Airlie wrote: > 2011/3/25 Michel Dänzer : > > On Fre, 2011-03-25 at 17:21 +1000, Dave Airlie wrote: > >> On Fri, Mar 25, 2011 at 10:17 AM, Linus Torvalds > >> wrote: > >> > On Thu, Mar 24, 2011 at 5:07 PM, Dave Airlie wrote: > >> >> > >> >> Like seriously you really think VFS locking rework wasn't under > >> >> development or discussion when you merged it? I'm sure Al would have > >> >> something to say about it considering the number of times he cursed in > >> >> irc about that code after you merged it. > >> > > >> > Umm. That code was basically over a year old by the time it was merged. > >> > > >> > How old was the code we're talking about now? Seriously? > >> > >> It was 30 lines of clean code, that really was fine to be merged in > >> its first form it was merely a future maintaince issue to clean up the > >> interface before it was released as stable. > > > > From my POV the real failure here was that the change made it to *any* > > tree while there were outstanding review issues from when it was > > initially discussed a few weeks earlier. Then when the change was > > submitted — more or less unchanged — I was on my birthday weekend > > enjoying some time away from computers, and when I had caught up with > > things, it was already in drm-next. > > Thats the problem really I read all the discussion and there wasn't > much that seemed bad, I think the problem with your suggestions was > there was a lot of latitude to disagree with them and I read the > comments and disagreed with them as well, and it fixed the problem so > I decided it should be pushed or we'd end up waiting another 6 months > to fix it for the people who it actually affects. This isn't the > message that I'd like to send to people who get off their arses and > fix our fuckups. The fuckup is in userspace trying to use a kernel interface which never pretended to work for more than 2 CRTCs for the third and above CRTCs. > >> In this case, if you had a >2 monitor setup connected to an evergreen > >> card, and you tried to do 3D on the 3rd monitor it would just hang the > >> app in a loop forever, the fix needs 3 pieces, one in the kernel, and > >> two userspace fixes. > > > > Actually, the hangs could be fixed in the X driver alone, but the author > > seems uninterested in contemplating that. Maybe because he seems to > > think it's easier to get the kernel fix to users, but I'm with you on > > that it's quite clearly the opposite. > > I can't see how you can actually fix the hangs in userspace, By not calling the kernel interface when you know it won't do what you want. > you can hack around the hangs so the user just gets a less useful behaviour > and make maintaining the userspace hack forever, or you can fix the > insufficient kernel interface and get it out quick. I'm not really > into the whole put a userspace hack in and maintain it for years thing > either, and I'd rather nobody else ever decided it was a good idea. Userspace has to check for the presence of the fixed kernel interface anyway. In the absence of it, the currently proposed fix just keeps the same old broken behaviour, risking hangs in some circumstances, when it could avoid them with possibly not too much effort. -- Earthling Michel Dänzer | http://www.vmware.com Libre software enthusiast | Debian, X and DRI developer From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel =?ISO-8859-1?Q?D=E4nzer?= Subject: Re: [git pull] drm fixes Date: Fri, 25 Mar 2011 09:00:45 +0100 Message-ID: <1301040045.12159.64.camel@thor.local> References: <1300864998.3522.71.camel@thor.local> <1300868532.3522.81.camel@thor.local> <1300880747.16522.13.camel@thor.local> <1301039010.12159.56.camel@thor.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id 9F7FA9E798 for ; Fri, 25 Mar 2011 01:01:00 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: Linus Torvalds , linux-kernel@vger.kernel.org, DRI mailing list List-Id: dri-devel@lists.freedesktop.org T24gRnJlLCAyMDExLTAzLTI1IGF0IDE3OjUxICsxMDAwLCBEYXZlIEFpcmxpZSB3cm90ZTogCj4g MjAxMS8zLzI1IE1pY2hlbCBEw6RuemVyIDxtaWNoZWxAZGFlbnplci5uZXQ+Ogo+ID4gT24gRnJl LCAyMDExLTAzLTI1IGF0IDE3OjIxICsxMDAwLCBEYXZlIEFpcmxpZSB3cm90ZToKPiA+PiBPbiBG cmksIE1hciAyNSwgMjAxMSBhdCAxMDoxNyBBTSwgTGludXMgVG9ydmFsZHMKPiA+PiA8dG9ydmFs ZHNAbGludXgtZm91bmRhdGlvbi5vcmc+IHdyb3RlOgo+ID4+ID4gT24gVGh1LCBNYXIgMjQsIDIw MTEgYXQgNTowNyBQTSwgRGF2ZSBBaXJsaWUgPGFpcmxpZWRAZ21haWwuY29tPiB3cm90ZToKPiA+ PiA+Pgo+ID4+ID4+IExpa2Ugc2VyaW91c2x5IHlvdSByZWFsbHkgdGhpbmsgVkZTIGxvY2tpbmcg cmV3b3JrIHdhc24ndCB1bmRlcgo+ID4+ID4+IGRldmVsb3BtZW50IG9yIGRpc2N1c3Npb24gd2hl biB5b3UgbWVyZ2VkIGl0PyBJJ20gc3VyZSBBbCB3b3VsZCBoYXZlCj4gPj4gPj4gc29tZXRoaW5n IHRvIHNheSBhYm91dCBpdCBjb25zaWRlcmluZyB0aGUgbnVtYmVyIG9mIHRpbWVzIGhlIGN1cnNl ZCBpbgo+ID4+ID4+IGlyYyBhYm91dCB0aGF0IGNvZGUgYWZ0ZXIgeW91IG1lcmdlZCBpdC4KPiA+ PiA+Cj4gPj4gPiBVbW0uIFRoYXQgY29kZSB3YXMgYmFzaWNhbGx5IG92ZXIgYSB5ZWFyIG9sZCBi eSB0aGUgdGltZSBpdCB3YXMgbWVyZ2VkLgo+ID4+ID4KPiA+PiA+IEhvdyBvbGQgd2FzIHRoZSBj b2RlIHdlJ3JlIHRhbGtpbmcgYWJvdXQgbm93PyBTZXJpb3VzbHk/Cj4gPj4KPiA+PiBJdCB3YXMg MzAgbGluZXMgb2YgY2xlYW4gY29kZSwgdGhhdCByZWFsbHkgd2FzIGZpbmUgdG8gYmUgbWVyZ2Vk IGluCj4gPj4gaXRzIGZpcnN0IGZvcm0gaXQgd2FzIG1lcmVseSBhIGZ1dHVyZSBtYWludGFpbmNl IGlzc3VlIHRvIGNsZWFuIHVwIHRoZQo+ID4+IGludGVyZmFjZSBiZWZvcmUgaXQgd2FzIHJlbGVh c2VkIGFzIHN0YWJsZS4KPiA+Cj4gPiBGcm9tIG15IFBPViB0aGUgcmVhbCBmYWlsdXJlIGhlcmUg d2FzIHRoYXQgdGhlIGNoYW5nZSBtYWRlIGl0IHRvICphbnkqCj4gPiB0cmVlIHdoaWxlIHRoZXJl IHdlcmUgb3V0c3RhbmRpbmcgcmV2aWV3IGlzc3VlcyBmcm9tIHdoZW4gaXQgd2FzCj4gPiBpbml0 aWFsbHkgZGlzY3Vzc2VkIGEgZmV3IHdlZWtzIGVhcmxpZXIuIFRoZW4gd2hlbiB0aGUgY2hhbmdl IHdhcwo+ID4gc3VibWl0dGVkIOKAlCBtb3JlIG9yIGxlc3MgdW5jaGFuZ2VkIOKAlCBJIHdhcyBv biBteSBiaXJ0aGRheSB3ZWVrZW5kCj4gPiBlbmpveWluZyBzb21lIHRpbWUgYXdheSBmcm9tIGNv bXB1dGVycywgYW5kIHdoZW4gSSBoYWQgY2F1Z2h0IHVwIHdpdGgKPiA+IHRoaW5ncywgaXQgd2Fz IGFscmVhZHkgaW4gZHJtLW5leHQuCj4gCj4gVGhhdHMgdGhlIHByb2JsZW0gcmVhbGx5IEkgcmVh ZCBhbGwgdGhlIGRpc2N1c3Npb24gYW5kIHRoZXJlIHdhc24ndAo+IG11Y2ggdGhhdCBzZWVtZWQg YmFkLCBJIHRoaW5rIHRoZSBwcm9ibGVtIHdpdGggeW91ciBzdWdnZXN0aW9ucyB3YXMKPiB0aGVy ZSB3YXMgYSBsb3Qgb2YgbGF0aXR1ZGUgdG8gZGlzYWdyZWUgd2l0aCB0aGVtIGFuZCBJIHJlYWQg dGhlCj4gY29tbWVudHMgYW5kIGRpc2FncmVlZCB3aXRoIHRoZW0gYXMgd2VsbCwgYW5kIGl0IGZp eGVkIHRoZSBwcm9ibGVtIHNvCj4gSSBkZWNpZGVkIGl0IHNob3VsZCBiZSBwdXNoZWQgb3Igd2Un ZCBlbmQgdXAgd2FpdGluZyBhbm90aGVyIDYgbW9udGhzCj4gdG8gZml4IGl0IGZvciB0aGUgcGVv cGxlIHdobyBpdCBhY3R1YWxseSBhZmZlY3RzLiBUaGlzIGlzbid0IHRoZQo+IG1lc3NhZ2UgdGhh dCBJJ2QgbGlrZSB0byBzZW5kIHRvIHBlb3BsZSB3aG8gZ2V0IG9mZiB0aGVpciBhcnNlcyBhbmQK PiBmaXggb3VyIGZ1Y2t1cHMuCgpUaGUgZnVja3VwIGlzIGluIHVzZXJzcGFjZSB0cnlpbmcgdG8g dXNlIGEga2VybmVsIGludGVyZmFjZSB3aGljaCBuZXZlcgpwcmV0ZW5kZWQgdG8gd29yayBmb3Ig bW9yZSB0aGFuIDIgQ1JUQ3MgZm9yIHRoZSB0aGlyZCBhbmQgYWJvdmUgQ1JUQ3MuCgoKPiA+PiBJ biB0aGlzIGNhc2UsIGlmIHlvdSBoYWQgYSA+MiBtb25pdG9yIHNldHVwIGNvbm5lY3RlZCB0byBh biBldmVyZ3JlZW4KPiA+PiBjYXJkLCBhbmQgeW91IHRyaWVkIHRvIGRvIDNEIG9uIHRoZSAzcmQg bW9uaXRvciBpdCB3b3VsZCBqdXN0IGhhbmcgdGhlCj4gPj4gYXBwIGluIGEgbG9vcCBmb3JldmVy LCB0aGUgZml4IG5lZWRzIDMgcGllY2VzLCBvbmUgaW4gdGhlIGtlcm5lbCwgYW5kCj4gPj4gdHdv IHVzZXJzcGFjZSBmaXhlcy4KPiA+Cj4gPiBBY3R1YWxseSwgdGhlIGhhbmdzIGNvdWxkIGJlIGZp eGVkIGluIHRoZSBYIGRyaXZlciBhbG9uZSwgYnV0IHRoZSBhdXRob3IKPiA+IHNlZW1zIHVuaW50 ZXJlc3RlZCBpbiBjb250ZW1wbGF0aW5nIHRoYXQuIE1heWJlIGJlY2F1c2UgaGUgc2VlbXMgdG8K PiA+IHRoaW5rIGl0J3MgZWFzaWVyIHRvIGdldCB0aGUga2VybmVsIGZpeCB0byB1c2VycywgYnV0 IEknbSB3aXRoIHlvdSBvbgo+ID4gdGhhdCBpdCdzIHF1aXRlIGNsZWFybHkgdGhlIG9wcG9zaXRl Lgo+IAo+IEkgY2FuJ3Qgc2VlIGhvdyB5b3UgY2FuIGFjdHVhbGx5IGZpeCB0aGUgaGFuZ3MgaW4g dXNlcnNwYWNlLCAKCkJ5IG5vdCBjYWxsaW5nIHRoZSBrZXJuZWwgaW50ZXJmYWNlIHdoZW4geW91 IGtub3cgaXQgd29uJ3QgZG8gd2hhdCB5b3UKd2FudC4KCj4geW91IGNhbiBoYWNrIGFyb3VuZCB0 aGUgaGFuZ3Mgc28gdGhlIHVzZXIganVzdCBnZXRzIGEgbGVzcyB1c2VmdWwgYmVoYXZpb3VyCj4g YW5kIG1ha2UgbWFpbnRhaW5pbmcgdGhlIHVzZXJzcGFjZSBoYWNrIGZvcmV2ZXIsIG9yIHlvdSBj YW4gZml4IHRoZQo+IGluc3VmZmljaWVudCBrZXJuZWwgaW50ZXJmYWNlIGFuZCBnZXQgaXQgb3V0 IHF1aWNrLiBJJ20gbm90IHJlYWxseQo+IGludG8gdGhlIHdob2xlIHB1dCBhIHVzZXJzcGFjZSBo YWNrIGluIGFuZCBtYWludGFpbiBpdCBmb3IgeWVhcnMgdGhpbmcKPiBlaXRoZXIsIGFuZCBJJ2Qg cmF0aGVyIG5vYm9keSBlbHNlIGV2ZXIgZGVjaWRlZCBpdCB3YXMgYSBnb29kIGlkZWEuCgpVc2Vy c3BhY2UgaGFzIHRvIGNoZWNrIGZvciB0aGUgcHJlc2VuY2Ugb2YgdGhlIGZpeGVkIGtlcm5lbCBp bnRlcmZhY2UKYW55d2F5LiBJbiB0aGUgYWJzZW5jZSBvZiBpdCwgdGhlIGN1cnJlbnRseSBwcm9w b3NlZCBmaXgganVzdCBrZWVwcyB0aGUKc2FtZSBvbGQgYnJva2VuIGJlaGF2aW91ciwgcmlza2lu ZyBoYW5ncyBpbiBzb21lIGNpcmN1bXN0YW5jZXMsIHdoZW4gaXQKY291bGQgYXZvaWQgdGhlbSB3 aXRoIHBvc3NpYmx5IG5vdCB0b28gbXVjaCBlZmZvcnQuCgoKLS0gCkVhcnRobGluZyBNaWNoZWwg RMOkbnplciAgICAgICAgICAgfCAgICAgICAgICAgICAgICBodHRwOi8vd3d3LnZtd2FyZS5jb20K TGlicmUgc29mdHdhcmUgZW50aHVzaWFzdCAgICAgICAgIHwgICAgICAgICAgRGViaWFuLCBYIGFu ZCBEUkkgZGV2ZWxvcGVyCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==