From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: forcewake junk, part2 Date: Sat, 9 Apr 2011 13:26:21 -0700 Message-ID: <1302380787-2957-1-git-send-email-ben@bwidawsk.net> References: <1302284850-8274-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com [184.106.247.128]) by gabe.freedesktop.org (Postfix) with ESMTP id AA3009E782 for ; Sat, 9 Apr 2011 13:27:01 -0700 (PDT) Received: from localhost.localdomain (unknown [67.208.96.87]) by cloud01.chad-versace.us (Postfix) with ESMTPSA id CE4241D406B for ; Sat, 9 Apr 2011 20:27:51 +0000 (UTC) In-Reply-To: <1302284850-8274-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org The request to test, and report the warnings is still desired. These address all of Chris' comments from IRC (I think). I tried to put the reasoning in the code comments, as well as commits; but I'll add it here for completeness. Simplify the acquisition of the forcewake lock by removing the forced entry. The motivation behind it is that the kernel offers sufficient tools to get relevant data before/during/after a hang, and adding a complex mechanism for userspace is not such a great idea. If a need to do this comes up, we can always add it back on a situational basis. Similarly, on releasing of the debugfs file, no more forced entry mechanism. This does leave a potential for release to hang, but AFAICS if release hangs, the system is going to need a reboot before i915 becomes usable again because module unload would also hang.