From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57121) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9Df-0002MO-Le for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QA9Da-0004zN-IN for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:31 -0400 Received: from hall.aurel32.net ([88.191.126.93]:56702) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QA9Da-0004xt-Aw for qemu-devel@nongnu.org; Wed, 13 Apr 2011 19:11:26 -0400 From: Aurelien Jarno Date: Thu, 14 Apr 2011 01:10:58 +0200 Message-Id: <1302736274-2908-4-git-send-email-aurelien@aurel32.net> In-Reply-To: <1302736274-2908-1-git-send-email-aurelien@aurel32.net> References: <1302736274-2908-1-git-send-email-aurelien@aurel32.net> Subject: [Qemu-devel] [PATCH v2 03/19] target-i386: use CPU_LDoubleU instead of a private union List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Laurent Vivier , Aurelien Jarno Use CPU_LDoubleU in cpu_dump_state() instead of redefining a union for doing the conversion. Based on a patch from Laurent Vivier . Cc: Laurent Vivier Reviewed-by: Peter Maydell Signed-off-by: Aurelien Jarno --- target-i386/helper.c | 12 +++--------- 1 files changed, 3 insertions(+), 9 deletions(-) diff --git a/target-i386/helper.c b/target-i386/helper.c index d15fca5..89df997 100644 --- a/target-i386/helper.c +++ b/target-i386/helper.c @@ -404,16 +404,10 @@ void cpu_dump_state(CPUState *env, FILE *f, fprintf_function cpu_fprintf, env->mxcsr); for(i=0;i<8;i++) { #if defined(USE_X86LDOUBLE) - union { - long double d; - struct { - uint64_t lower; - uint16_t upper; - } l; - } tmp; - tmp.d = env->fpregs[i].d; + CPU_LDoubleU u; + u.d = env->fpregs[i].d; cpu_fprintf(f, "FPR%d=%016" PRIx64 " %04x", - i, tmp.l.lower, tmp.l.upper); + i, u.l.lower, u.l.upper); #else cpu_fprintf(f, "FPR%d=%016" PRIx64, i, env->fpregs[i].mmx.q); -- 1.7.2.3