All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86, AMD: K8 Rev.A-E processors are subject to erratum 400
@ 2011-04-29 21:47 Boris Ostrovsky
  2011-05-01 16:58 ` [tip:x86/urgent] x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors tip-bot for Boris Ostrovsky
  0 siblings, 1 reply; 2+ messages in thread
From: Boris Ostrovsky @ 2011-04-29 21:47 UTC (permalink / raw)
  To: x86; +Cc: linux-kernel, jvpeetz, borislav.petkov, boris.ostrovsky, stable

Older AMD K8 processors (Revisions A-E) are affected by erratum 400
(APIC timer interrupts don't occur in C states greater than C1). This,
for example, means that X86_FEATURE_ARAT flag should not be set for
these parts.

This addresses regression introduced by commit
b87cf80af3ba4b4c008b4face3c68d604e1715c6 ("x86, AMD: Set ARAT feature
on AMD processors") where the system may become unresponsive until
external interrupt (such as keyboard input) occurs. This results, for
example, in time not being reported correctly, lack of progress on the
system and other lockups.

Signed-off-by: Boris Ostrovsky <Boris.Ostrovsky@amd.com>
Acked-by: Borislav Petkov <borislav.petkov@amd.com>
Reported-by: Joerg-Volker Peetz <jvpeetz@web.de>
Tested-by: Joerg-Volker Peetz <jvpeetz@web.de>
Cc: stable@kernel.org

---
 arch/x86/kernel/cpu/amd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 3532d3b..71499b4 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -698,7 +698,7 @@ cpu_dev_register(amd_cpu_dev);
  */
 
 const int amd_erratum_400[] =
-	AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0xf, 0x41, 0x2, 0xff, 0xf),
+	AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0xf, 0x4, 0x2, 0xff, 0xf),
 			    AMD_MODEL_RANGE(0x10, 0x2, 0x1, 0xff, 0xf));
 EXPORT_SYMBOL_GPL(amd_erratum_400);
 
-- 
1.7.3.4


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [tip:x86/urgent] x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors
  2011-04-29 21:47 [PATCH] x86, AMD: K8 Rev.A-E processors are subject to erratum 400 Boris Ostrovsky
@ 2011-05-01 16:58 ` tip-bot for Boris Ostrovsky
  0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Boris Ostrovsky @ 2011-05-01 16:58 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, Boris.Ostrovsky, hpa, mingo, jvpeetz, tglx, ostr,
	mingo, borislav.petkov

Commit-ID:  e20a2d205c05cef6b5783df339a7d54adeb50962
Gitweb:     http://git.kernel.org/tip/e20a2d205c05cef6b5783df339a7d54adeb50962
Author:     Boris Ostrovsky <ostr@amd64.org>
AuthorDate: Fri, 29 Apr 2011 17:47:43 -0400
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Sun, 1 May 2011 18:55:51 +0200

x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors

Older AMD K8 processors (Revisions A-E) are affected by erratum
400 (APIC timer interrupts don't occur in C states greater than
C1). This, for example, means that X86_FEATURE_ARAT flag should
not be set for these parts.

This addresses regression introduced by commit
b87cf80af3ba4b4c008b4face3c68d604e1715c6 ("x86, AMD: Set ARAT
feature on AMD processors") where the system may become
unresponsive until external interrupt (such as keyboard input)
occurs. This results, for example, in time not being reported
correctly, lack of progress on the system and other lockups.

Reported-by: Joerg-Volker Peetz <jvpeetz@web.de>
Tested-by: Joerg-Volker Peetz <jvpeetz@web.de>
Acked-by: Borislav Petkov <borislav.petkov@amd.com>
Signed-off-by: Boris Ostrovsky <Boris.Ostrovsky@amd.com>
Cc: stable@kernel.org
Link: http://lkml.kernel.org/r/1304113663-6586-1-git-send-email-ostr@amd64.org
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/cpu/amd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/cpu/amd.c b/arch/x86/kernel/cpu/amd.c
index 3532d3b..bb9eb29 100644
--- a/arch/x86/kernel/cpu/amd.c
+++ b/arch/x86/kernel/cpu/amd.c
@@ -698,7 +698,7 @@ cpu_dev_register(amd_cpu_dev);
  */
 
 const int amd_erratum_400[] =
-	AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0xf, 0x41, 0x2, 0xff, 0xf),
+	AMD_OSVW_ERRATUM(1, AMD_MODEL_RANGE(0x0f, 0x4, 0x2, 0xff, 0xf),
 			    AMD_MODEL_RANGE(0x10, 0x2, 0x1, 0xff, 0xf));
 EXPORT_SYMBOL_GPL(amd_erratum_400);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-01 16:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-29 21:47 [PATCH] x86, AMD: K8 Rev.A-E processors are subject to erratum 400 Boris Ostrovsky
2011-05-01 16:58 ` [tip:x86/urgent] x86, AMD: Fix APIC timer erratum 400 affecting K8 Rev.A-E processors tip-bot for Boris Ostrovsky

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.