All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] OMAP4: fix return value of omap4_l3_init
@ 2011-05-07 16:58 ` Rabin Vincent
  0 siblings, 0 replies; 6+ messages in thread
From: Rabin Vincent @ 2011-05-07 16:58 UTC (permalink / raw)
  To: tony; +Cc: linux-omap, linux-arm-kernel, Rabin Vincent

Don't PTR_ERR() a non-error pointer:

 initcall omap4_l3_init+0x0/0xdc returned -544980480 after 0 usecs
 initcall omap4_l3_init+0x0/0xdc returned with error code -544980480

Signed-off-by: Rabin Vincent <rabin@rab.in>
---
 arch/arm/mach-omap2/devices.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c
index 7b85585..5b8ca68 100644
--- a/arch/arm/mach-omap2/devices.c
+++ b/arch/arm/mach-omap2/devices.c
@@ -97,7 +97,7 @@ static int __init omap4_l3_init(void)
 
 	WARN(IS_ERR(od), "could not build omap_device for %s\n", oh_name);
 
-	return PTR_ERR(od);
+	return IS_ERR(od) ? PTR_ERR(od) : 0;
 }
 postcore_initcall(omap4_l3_init);
 
-- 
1.7.4.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-05-31 11:52 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-07 16:58 [PATCH] OMAP4: fix return value of omap4_l3_init Rabin Vincent
2011-05-07 16:58 ` Rabin Vincent
2011-05-18 15:53 ` Rabin Vincent
2011-05-18 15:53   ` Rabin Vincent
2011-05-31 11:52 ` Tony Lindgren
2011-05-31 11:52   ` Tony Lindgren

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.