From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Jackson Subject: [PATCH 05/14] libxl: disks: expose new "script" parameter for external block scripts Date: Thu, 12 May 2011 15:36:35 +0100 Message-ID: <1305211004-31687-6-git-send-email-ian.jackson@eu.citrix.com> References: <1305211004-31687-1-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-2-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-3-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-4-git-send-email-ian.jackson@eu.citrix.com> <1305211004-31687-5-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1305211004-31687-5-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Ian Jackson , Ian Jackson List-Id: xen-devel@lists.xenproject.org This is not currently implemented. Applications setting it to anything but NULL will cause an error. Code to set it from xl configuration files will appear later in this series. Signed-off-by: Ian Jackson --- tools/libxl/libxl.c | 7 +++++++ tools/libxl/libxl.idl | 1 + 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index d4a47f2..ac7b68a 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -968,6 +968,13 @@ int libxl_device_disk_add(libxl_ctx *ctx, uint32_t domid, libxl_device_disk *dis goto out_free; } + if (disk->script) { + LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "External block scripts" + " not yet supported, sorry"); + rc = ERROR_INVAL; + goto out_free; + } + devid = libxl__device_disk_dev_number(disk->vdev, NULL, NULL); if (devid==-1) { LIBXL__LOG(ctx, LIBXL__LOG_ERROR, "Invalid or unsupported" diff --git a/tools/libxl/libxl.idl b/tools/libxl/libxl.idl index a5be66f..546cd3c 100644 --- a/tools/libxl/libxl.idl +++ b/tools/libxl/libxl.idl @@ -261,6 +261,7 @@ libxl_device_disk = Struct("device_disk", [ ("vdev", string), ("backend", libxl_disk_backend), ("format", libxl_disk_format), + ("script", string), ("unpluggable", integer), ("readwrite", integer), ("is_cdrom", integer), -- 1.7.2.5