From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH] Fix save.py bug Date: Fri, 13 May 2011 15:36:18 +0100 Message-ID: <1305297378.31488.132.camel@zakaz.uk.xensource.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Liu, Jinsong" Cc: Rajagopalan , "xen-devel@lists.xensource.com" , Ian Jackson , Keir Fraser , Shriram List-Id: xen-devel@lists.xenproject.org Adding Remus maintainer. You can consult the MAINTAINERS file at the top level to fix this. On Fri, 2011-05-13 at 15:26 +0100, Liu, Jinsong wrote: > I don't know python well, but when I compile at my platform, compile error as: > > > ======================= > ... > Parsing libxl.idl > cmp: _libxl_paths.h.tmp: No such file or directory > cmp: _libxl_paths.h: No such file or directory > cmp: xen/util/path.py: No such file or directory > Parsing /otc/source/vtd/xen-unstable/tools/python/../../tools/libxl/libxl.idl > File "/usr/lib64/python2.4/site-packages/xen/remus/save.py", line 169 > finally: > ^ > SyntaxError: invalid syntax > ... > > ====================== > > > This kind of compile error introduced from c/s 23195. > This patch revert it. That seems rather extreme in the first instance. >>From a quick google It seems that python 2.4 did not properly support the "try: ... except: ... finally: ... " syntax. It appears that as a workaround one can do try: try: ... except: ... finally: ... But I didn't try this myself. Ian.