All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] rootfs_ipk: respect ONLINE_PACKAGE_MANAGEMENT
Date: Tue, 17 May 2011 17:22:11 +0100	[thread overview]
Message-ID: <1305649331.3424.259.camel@rex> (raw)
In-Reply-To: <1305643833.2429.264.camel@phil-desktop>

On Tue, 2011-05-17 at 15:50 +0100, Phil Blundell wrote:
> On Tue, 2011-05-17 at 15:24 +0100, Richard Purdie wrote:
> > What's wrong with:
> > 
> > ROOTFS_POSTPROCESS_COMMAND += "remove_packaging_data_files ; "
> > 
> > as used in the minimal image? The nice thing about this is it works over
> > several package backends too...
> 
> Well, conceptually it seems a bit nicer to have the rootfs constructor
> obey the same variable that is used to control package management
> functionality elsewhere (not that oe-core currently has any "elsewhere",
> but oe master does and I would like to backport that functionality to
> oe-core as well). 
> 
> There's also the minor issue that rootfs_ipk's implementation of
> remove_packaging_data_files() does leave an empty directory behind,
> which I don't especially want in the O_P_M=none case, so I'd end up
> having to do some further cleanup of my own.
> 
> I guess I could teach remove_packaging_data_files() to not create the
> empty directory if O_P_M=="none".  Would you be happier with that?

Mostly. The question remains what happens if there are postinstalls that
are expecting to run on the device. I'm guessing that is why the mkdir
is there since at present we don't want to break the postinstalls.

The answer could be we ensure that directory exists if postinstalls
exist...

Cheers,

Richard






  reply	other threads:[~2011-05-17 16:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-17 13:55 [PATCH] rootfs_ipk: respect ONLINE_PACKAGE_MANAGEMENT Phil Blundell
2011-05-17 14:24 ` Richard Purdie
2011-05-17 14:50   ` Phil Blundell
2011-05-17 16:22     ` Richard Purdie [this message]
2011-05-18 15:37       ` Phil Blundell
2011-05-19 10:15         ` Richard Purdie
2011-05-19 10:31           ` Phil Blundell
2011-05-19 11:21             ` Richard Purdie
2011-05-19 11:41               ` Phil Blundell
2011-05-19 12:16                 ` Richard Purdie
2011-05-19 15:04                   ` Phil Blundell
2011-05-19 15:08                     ` Richard Purdie
2011-05-24 13:59                       ` Phil Blundell
2011-05-24 14:12                         ` Richard Purdie
2011-05-24 14:16                           ` Phil Blundell
2011-05-19 16:58               ` Chris Larson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305649331.3424.259.camel@rex \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.