From: Nishanth Menon <nm@ti.com>
To: kevin <khilman@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>, Nishanth Menon <nm@ti.com>
Subject: [PM-WIP_CPUFREQ][PATCH 2/6 v2] OMAP2+: cpufreq: handle invalid cpufreq table
Date: Wed, 18 May 2011 02:37:42 -0500 [thread overview]
Message-ID: <1305704266-17623-3-git-send-email-nm@ti.com> (raw)
In-Reply-To: <[PM-WIP_CPUFREQ][PATCH 0/5] Cleanups for cpufreq>
Handle the case when cpufreq_frequency_table_cpuinfo fails. freq_table
that we passed failed the internal test of cpufreq generic driver,
so we should'nt be using the freq_table as such. Instead, warn and
fallback to clock functions for validation and operation.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
arch/arm/mach-omap2/omap2plus-cpufreq.c | 12 ++++++++++--
1 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap2plus-cpufreq.c b/arch/arm/mach-omap2/omap2plus-cpufreq.c
index e38ebb8..6e3666a 100644
--- a/arch/arm/mach-omap2/omap2plus-cpufreq.c
+++ b/arch/arm/mach-omap2/omap2plus-cpufreq.c
@@ -182,10 +182,18 @@ static int __cpuinit omap_cpu_init(struct cpufreq_policy *policy)
if (freq_table) {
result = cpufreq_frequency_table_cpuinfo(policy, freq_table);
- if (!result)
+ if (!result) {
cpufreq_frequency_table_get_attr(freq_table,
policy->cpu);
- } else {
+ } else {
+ WARN(true, "%s: fallback to clk_round(freq_table=%d)\n",
+ __func__, result);
+ kfree(freq_table);
+ freq_table = NULL;
+ }
+ }
+
+ if (!freq_table) {
policy->cpuinfo.min_freq = clk_round_rate(mpu_clk, 0) / 1000;
policy->cpuinfo.max_freq = clk_round_rate(mpu_clk,
VERY_HI_RATE) / 1000;
--
1.7.1
next prev parent reply other threads:[~2011-05-18 7:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PM-WIP_CPUFREQ][PATCH 0/5] Cleanups for cpufreq>
2011-05-18 7:37 ` [PM-WIP_CPUFREQ][PATCH 0/6 v2] Cleanups for cpufreq Nishanth Menon
2011-05-18 7:37 ` [PM-WIP_CPUFREQ][PATCH 1/6 v2] OMAP2+: cpufreq: free up table on exit Nishanth Menon
2011-05-19 10:26 ` Kevin Hilman
2011-05-19 13:48 ` Menon, Nishanth
2011-05-18 7:37 ` Nishanth Menon [this message]
2011-05-18 7:37 ` [PM-WIP_CPUFREQ][PATCH 3/6 v2] OMAP2+: cpufreq: minor comment cleanup Nishanth Menon
2011-05-18 20:08 ` Todd Poynor
2011-05-18 20:34 ` Menon, Nishanth
2011-05-18 7:37 ` [PM-WIP_CPUFREQ][PATCH 4/6 v2] OMAP2: cpufreq: use clk_init_cpufreq_table if OPPs not available Nishanth Menon
2011-05-19 13:12 ` Kevin Hilman
2011-05-19 13:51 ` Menon, Nishanth
2011-05-25 0:01 ` Kevin Hilman
2011-05-25 7:44 ` Menon, Nishanth
2011-05-18 7:37 ` [PM-WIP_CPUFREQ][PATCH 5/6 v2] OMAP2+: cpufreq: use cpufreq_frequency_table_target Nishanth Menon
2011-05-18 7:37 ` [PM-WIP_CPUFREQ][PATCH 6/6 v2] OMAP2+: cpufreq: fix freq_table leak Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305704266-17623-3-git-send-email-nm@ti.com \
--to=nm@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.