Re: [PATCH 3/5] classes/package(prserv).bbclass: Added PR service support.

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2011-05-19 at 18:29 +0800, Lianhao Lu wrote:
> From: Lianhao Lu <lianhao.lu@intel.com>
> 
> 1. Added package_get_auto_rev to PACKAGEFUNCS to get the auto
> incremented value(PRAUTO) from remote PR service.
> 
> 2. Save PRFORMAT to pkgdata to be used by package_write_xxx.
> 
> 3. Added supporting functions in prserv.bbclass.
> 
> Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
> ---
>  meta/classes/package.bbclass |   36 +++++++++++++++++++++++++-----------
>  meta/classes/prserv.bbclass  |   29 +++++++++++++++++++++++++++++
>  2 files changed, 54 insertions(+), 11 deletions(-)
>  create mode 100644 meta/classes/prserv.bbclass
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index 4eb349d..efadbbd 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -324,6 +327,15 @@ def runtime_mapping_rename (varname, d):
>  # Package functions suitable for inclusion in PACKAGEFUNCS
>  #
>  
> +python package_get_auto_rev() {
> +	if bb.data.getVar('USE_PR_SERV', d, True):
> +		auto_rev=get_auto_rev(d)
> +		if auto_rev is None:
> +			bb.fatal("Can NOT get auto revision from remote PR service")
> +			return
> +		bb.data.setVar('PRAUTO',str(auto_rev),d)
> +}
> +
>  python package_do_split_locales() {
>  	if (bb.data.getVar('PACKAGE_NO_LOCALE', d, True) == '1'):
>  		bb.debug(1, "package requested not splitting locales")

This looks a little confusing to me as at first glance I'd have said it
was related to SRCREV auto incrementing. Can we add something to to with
pr to the function name? Function names like get_auto_rev() and
make_conf() also need clearer namespacing to include prserv as a prefix
so its clearer where the functions are from and what they do.

Cheers,

Richard