From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50262) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN2NZ-0002Rg-KA for qemu-devel@nongnu.org; Thu, 19 May 2011 08:31:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QN2NX-0003u7-Hi for qemu-devel@nongnu.org; Thu, 19 May 2011 08:31:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QN2NX-0003tt-Ak for qemu-devel@nongnu.org; Thu, 19 May 2011 08:30:59 -0400 From: Kevin Wolf Date: Thu, 19 May 2011 14:33:21 +0200 Message-Id: <1305808412-16994-8-git-send-email-kwolf@redhat.com> In-Reply-To: <1305808412-16994-1-git-send-email-kwolf@redhat.com> References: <1305808412-16994-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 07/18] ahci: Fix crashes on duplicate BH registration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Jan Kiszka If ahci_dma_set_inactive is called a while there is still a pending BH from a previous run, we will crash on the second run of ahci_check_cmd_bh as it overwrites AHCIDevice::check_bh. Avoid this broken and redundant duplicate registration. Signed-off-by: Jan Kiszka Signed-off-by: Kevin Wolf --- hw/ide/ahci.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index c6e0c77..744d19d 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -1066,9 +1066,11 @@ static int ahci_dma_set_inactive(IDEDMA *dma) ad->dma_cb = NULL; - /* maybe we still have something to process, check later */ - ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad); - qemu_bh_schedule(ad->check_bh); + if (!ad->check_bh) { + /* maybe we still have something to process, check later */ + ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad); + qemu_bh_schedule(ad->check_bh); + } return 0; } -- 1.7.2.3