All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Cromie <jim.cromie@gmail.com>
To: rdunlap@xenotime.net
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Jim Cromie <jim.cromie@gmail.com>
Subject: [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr.
Date: Mon, 23 May 2011 12:44:57 -0600	[thread overview]
Message-ID: <1306176297-6964-4-git-send-email-jim.cromie@gmail.com> (raw)
In-Reply-To: <1306176297-6964-1-git-send-email-jim.cromie@gmail.com>

Also count CONFIG_MODVERSIONS warnings, and print a NOTE at start of
SECTION 2 if any were issued.  Section 2 will be empty if the build is
lacking this CONFIG_ item, and user may have missed the warnings, as
they're off screen.

Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
 scripts/export_report.pl |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/scripts/export_report.pl b/scripts/export_report.pl
index 48398a1..8f79b70 100644
--- a/scripts/export_report.pl
+++ b/scripts/export_report.pl
@@ -102,6 +102,8 @@ close($module_symvers);
 #
 # collect the usage count of each symbol.
 #
+my $modversion_warnings = 0;
+
 foreach my $thismod (@allcfiles) {
 	my $module;
 
@@ -132,7 +134,8 @@ foreach my $thismod (@allcfiles) {
 		}
 	}
 	if ($state != 2) {
-		print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";
+		warn "WARNING:$thismod is not built with CONFIG_MODVERSIONS enabled\n";
+		$modversion_warnings++;
 	}
 	close($module);
 }
@@ -166,6 +169,9 @@ printf("SECTION 2:\n\tThis section reports export-symbol-usage of in-kernel
 modules. Each module lists the modules, and the symbols from that module that
 it uses.  Each listed symbol reports the number of modules using it\n");
 
+print "\nNOTE: Got $modversion_warnings CONFIG_MODVERSIONS warnings\n\n"
+    if $modversion_warnings;
+
 print "~"x80 , "\n";
 for my $thismod (sort keys %MODULE) {
 	my $list = $MODULE{$thismod};
-- 
1.7.4.4


  parent reply	other threads:[~2011-05-23 18:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21  8:21 [PATCH 0/3] fixes, improvements on scripts/export_report.pl Jim Cromie
2011-05-21  8:21 ` [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline Jim Cromie
2011-05-23  2:16   ` Randy Dunlap
2011-05-23  2:16     ` Randy Dunlap
2011-05-21  8:21 ` [PATCH 2/3] sort SECTION 2 output of scripts/export_report.pl Jim Cromie
2011-05-21  8:21 ` [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr Jim Cromie
2011-05-23 15:21   ` Randy Dunlap
2011-05-23 18:44   ` [PATCH 0/3 rev2] fix scripts/export_report.pl Jim Cromie
2011-05-23 18:44     ` [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline Jim Cromie
2011-05-23 18:44     ` [PATCH 2/3] sort SECTION 2 output of scripts/export_report.pl Jim Cromie
2011-05-23 18:44     ` Jim Cromie [this message]
2011-05-24 14:10     ` [PATCH 0/3 rev2] fix scripts/export_report.pl Michal Marek
2011-05-24 17:53       ` Jim Cromie
2011-05-25 12:15         ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306176297-6964-4-git-send-email-jim.cromie@gmail.com \
    --to=jim.cromie@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.