From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCHv2 2/2] OMAP: add omap_device_reset() Date: Mon, 30 May 2011 09:00:04 +0300 Message-ID: <1306735204.2117.12.camel@deskari> References: <1306481908-7386-1-git-send-email-tomi.valkeinen@ti.com> <1306481908-7386-3-git-send-email-tomi.valkeinen@ti.com> <4DDF9B5D.7060408@ti.com> <1306500367.1905.18.camel@deskari> <4DDFB8AF.1080800@ti.com> <1306514427.1905.27.camel@deskari> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog108.obsmtp.com ([74.125.149.199]:51662 "EHLO na3sys009aog108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181Ab1E3GAJ (ORCPT ); Mon, 30 May 2011 02:00:09 -0400 Received: by ewy3 with SMTP id 3so1630112ewy.22 for ; Sun, 29 May 2011 23:00:07 -0700 (PDT) In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Paul Walmsley Cc: "Cousson, Benoit" , "Hilman, Kevin" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" On Sun, 2011-05-29 at 20:15 -0600, Paul Walmsley wrote: > On Fri, 27 May 2011, Tomi Valkeinen wrote: > > > However, VENC doesn't use the standard syscontrol mechanism, so that > > cannot be done via omap_device interface anyway. > > struct omap_hwmod_class has a .reset function pointer for this purpose. > It's already been necessary to deal with the I2C IP block: > > https://patchwork.kernel.org/patch/804072/ > > If all that's needed are the steps in 4430 TRM Rev. T Section 10.6.5.1.2.3 > "Subsequence--Video Encoder Software Reset", then it should be possible to > handle this internal reset with hwmod code. Yes, that should be enough. However, the VENC_F_CONTROL register also contains bits that need to be programmed by the driver. I hope that doesn't cause any problems. Probably not, as hwmod code should use that register only at reset time. Tomi From mboxrd@z Thu Jan 1 00:00:00 1970 From: tomi.valkeinen@ti.com (Tomi Valkeinen) Date: Mon, 30 May 2011 09:00:04 +0300 Subject: [PATCHv2 2/2] OMAP: add omap_device_reset() In-Reply-To: References: <1306481908-7386-1-git-send-email-tomi.valkeinen@ti.com> <1306481908-7386-3-git-send-email-tomi.valkeinen@ti.com> <4DDF9B5D.7060408@ti.com> <1306500367.1905.18.camel@deskari> <4DDFB8AF.1080800@ti.com> <1306514427.1905.27.camel@deskari> Message-ID: <1306735204.2117.12.camel@deskari> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 2011-05-29 at 20:15 -0600, Paul Walmsley wrote: > On Fri, 27 May 2011, Tomi Valkeinen wrote: > > > However, VENC doesn't use the standard syscontrol mechanism, so that > > cannot be done via omap_device interface anyway. > > struct omap_hwmod_class has a .reset function pointer for this purpose. > It's already been necessary to deal with the I2C IP block: > > https://patchwork.kernel.org/patch/804072/ > > If all that's needed are the steps in 4430 TRM Rev. T Section 10.6.5.1.2.3 > "Subsequence--Video Encoder Software Reset", then it should be possible to > handle this internal reset with hwmod code. Yes, that should be enough. However, the VENC_F_CONTROL register also contains bits that need to be programmed by the driver. I hope that doesn't cause any problems. Probably not, as hwmod code should use that register only at reset time. Tomi