From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <Ian.Campbell@eu.citrix.com>
Subject: Re: [Xen-devel] Re: [RFC] [PATCH 0/2] Basic SeaBIOS
 support for Xen HVM
Date: Wed, 1 Jun 2011 10:17:47 +0100
Message-ID: <1306919867.775.221.camel@zakaz.uk.xensource.com>
References: <1305535468.31488.202.camel@zakaz.uk.xensource.com>
	<20110516233901.GA12092@morn.localdomain>
	<1305647948.20907.72.camel@zakaz.uk.xensource.com>
	<1306147478.20576.85.camel@zakaz.uk.xensource.com>
	<20110524001759.GC28567@morn.localdomain>
	<1306234927.20576.155.camel@zakaz.uk.xensource.com>
	<20110525024457.GB25115@morn.localdomain>
	<1306422817.775.48.camel@zakaz.uk.xensource.com>
	<20110527012001.GA374@morn.localdomain>
	<1306488434.775.87.camel@zakaz.uk.xensource.com>
	<20110530144353.GB18839@morn.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <seabios-bounces@seabios.org>
In-Reply-To: <20110530144353.GB18839@morn.localdomain>
List-Unsubscribe: <http://www.seabios.org/mailman/options/seabios>,
	<mailto:seabios-request@seabios.org?subject=unsubscribe>
List-Archive: <http://www.seabios.org/pipermail/seabios>
List-Post: <mailto:seabios@seabios.org>
List-Help: <mailto:seabios-request@seabios.org?subject=help>
List-Subscribe: <http://www.seabios.org/mailman/listinfo/seabios>,
	<mailto:seabios-request@seabios.org?subject=subscribe>
Errors-To: seabios-bounces@seabios.org
Sender: seabios-bounces@seabios.org
To: Kevin O'Connor <kevin@koconnor.net>
Cc: xen-devel <xen-devel@lists.xensource.com>, "seabios@seabios.org" <seabios@seabios.org>
List-Id: xen-devel@lists.xenproject.org

On Mon, 2011-05-30 at 15:43 +0100, Kevin O'Connor wrote:
> On Fri, May 27, 2011 at 10:27:14AM +0100, Ian Campbell wrote:
> > On Fri, 2011-05-27 at 02:20 +0100, Kevin O'Connor wrote:
> > > Will Xen support the fw_cfg interface?
> > I don't think so, at least not in general. (fw_cfg is the qemu thing on
> > ports 0x510/511, right?)
> 
> Yes - 0x510/0x511.
> 
> [...]
> > The existing ad-hoc structure I've defined is:
> >         struct xen_seabios_info {
> >             char signature[14]; /* XenHVMSeaBIOS\0 */
> >             u16 length;
> >             u32 acpi_rsdp;
> >             u32 mptable;
> >             u32 e820_nr;
> >             struct e820entry e820[128];
> >             u8 checksum;
> >         };
> > so I was mainly thinking of e.g. CB_TAG_MEMORY along with CB_MEM_TABLE.
> > 
> > I think I'll stick with defining a structure myself, these things are
> > all discoverable via signatures so we can always transition in the
> > future.
> 
> At some point, Xen will likely need "romfile" support (see
> src/paravirt.h) in order to support pulling in non-device option roms

What sorts of things live in those?

> and things like "bootorder" support.  The "romfile" stuff just uses a
> list of ("name", size, data) 3-tuples to pass in arbitrary data to
> SeaBIOS.  You may wish to consider supporting an interface like that
> from the start.

The datastructure I'm proposing above would only be used to propagate
information hvmloader itself has created (BIOS tables) through to
SeaBios. hvmloader doesn't have any insight into things like bootorder
etc so it wouldn't be able to create tables of that type.

The other stuff sounds like the sort of thing Xen would normally
communicate from the toolstack to the guest using xenstore, unless the
payloads are huge? The fw_cfg remains an option for this sort of data
too, if that turns out to make sense.

I'll be posting the next version of the patch shortly.

Thanks,
Ian.