From: Ben Hutchings <bhutchings@solarflare.com>
To: Jiri Pirko <jpirko@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [patch net-next-2.6] de2104x: use speed defines instead of number
Date: Wed, 01 Jun 2011 18:26:34 +0100 [thread overview]
Message-ID: <1306949194.2758.1.camel@bwh-desktop> (raw)
In-Reply-To: <20110601161932.GA2784@psychotron.redhat.com>
On Wed, 2011-06-01 at 18:19 +0200, Jiri Pirko wrote:
> Wed, Jun 01, 2011 at 05:46:46PM CEST, bhutchings@solarflare.com wrote:
> >The speed/speed_hi fields are defined to hold speed in Mbit/s, not only
> >specific values. I don't see any reason to use the names any more.
>
> Do you mean to remove SPEED_X defines in whole code?
[...]
I have higher priorities - but I would happy to see someone do that.
The definitions have to stay in <linux/ethtool.h> for user space,
though.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
prev parent reply other threads:[~2011-06-01 17:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 14:14 [patch net-next-2.6] de2104x: use speed defines instead of number Jiri Pirko
2011-06-01 15:46 ` Ben Hutchings
2011-06-01 16:19 ` Jiri Pirko
2011-06-01 17:26 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306949194.2758.1.camel@bwh-desktop \
--to=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=jpirko@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.