All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH 4/5] Fix segfault on screendump with -nographic
Date: Thu,  2 Jun 2011 08:33:02 +0200	[thread overview]
Message-ID: <1306996383-27950-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1306996383-27950-1-git-send-email-agraf@suse.de>

When running -nographic and calling "screendump" on the monitor, qemu
segfaults. Fix the invalid pointer dereference by checking for NULL.

Signed-off-by: Alexander Graf <agraf@suse.de>
---
 console.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/console.c b/console.c
index 871c1d4..9c6addf 100644
--- a/console.c
+++ b/console.c
@@ -180,7 +180,7 @@ void vga_hw_screen_dump(const char *filename)
     active_console = consoles[0];
     /* There is currently no way of specifying which screen we want to dump,
        so always dump the first one.  */
-    if (consoles[0]->hw_screen_dump)
+    if (consoles[0] && consoles[0]->hw_screen_dump)
         consoles[0]->hw_screen_dump(consoles[0]->hw, filename);
     active_console = previous_active_console;
 }
-- 
1.6.0.2

  parent reply	other threads:[~2011-06-03 11:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-02  6:32 [Qemu-devel] [PULL 0/5] PPC patch queue June 03 2011 Alexander Graf
2011-06-02  6:32 ` [Qemu-devel] [PATCH 1/5] ppc: Fix compilation for ppc64-softmmu Alexander Graf
2011-06-02  6:33 ` [Qemu-devel] [PATCH 2/5] PPC: fix sregs usage on booke Alexander Graf
2011-06-02  6:33 ` [Qemu-devel] [PATCH 3/5] PPC: install mpc8544ds.dtb Alexander Graf
2011-06-02  6:33 ` Alexander Graf [this message]
2011-06-02  6:33 ` [Qemu-devel] [PATCH 5/5] PPC: fix mpc8544ds pci default devices Alexander Graf
2011-06-03 16:15 ` [Qemu-devel] [PULL 0/5] PPC patch queue June 03 2011 Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1306996383-27950-5-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.