From mboxrd@z Thu Jan  1 00:00:00 1970
From: York Sun <yorksun@freescale.com>
Date: Wed, 8 Jun 2011 06:49:22 +0800
Subject: [U-Boot] [Patch v2 1/2] powerpc/mpc8xxx: Enable calculation for
 fixed DDR chips
In-Reply-To: <0E5B0091-AD32-48A9-A9F5-B59684A6CF53@kernel.crashing.org>
References: <1307410937-13861-1-git-send-email-yorksun@freescale.com>
	<1307410937-13861-2-git-send-email-yorksun@freescale.com>
	<0E5B0091-AD32-48A9-A9F5-B59684A6CF53@kernel.crashing.org>
Message-ID: <1307486962.29305.6.camel@oslab-l1>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, 2011-06-07 at 08:35 -0500, Kumar Gala wrote:
> > +- CONFIG_SYS_DDR_RAW_TIMING
> > +		Get DDR timing information from other than SPD. Common with
> > +		soldered DDR chips onboard without SPD. DDR raw timing
> > +		parameters are extracted from datasheet and hard-coded into
> > +		header files or board specific files.
> > +
> 
> How is this not just !CONFIG_SPD ?

There are boards with fixed DDR in the past. They didn't use SPD.

> > +/* board specific function */
> > +#ifdef CONFIG_SYS_DDR_RAW_TIMING
> > +int fsl_ddr_get_dimm_params(dimm_params_t *pdimm,
> > +			unsigned int controller_number,
> > +			unsigned int dimm_number);
> 
> where is this code?

This code is in board ddr.c file. It is board specific.

York