From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756757Ab1FIXAH (ORCPT ); Thu, 9 Jun 2011 19:00:07 -0400 Received: from merlin.infradead.org ([205.233.59.134]:35957 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932115Ab1FIW76 (ORCPT ); Thu, 9 Jun 2011 18:59:58 -0400 Subject: Re: [PATCH v4 3.0-rc2-tip 2/22] 2: uprobes: Breakground page replacement. From: Peter Zijlstra To: Srikar Dronamraju Cc: Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Masami Hiramatsu , Hugh Dickins , Christoph Hellwig , Andi Kleen , Thomas Gleixner , Jonathan Corbet , Oleg Nesterov , Andrew Morton , Jim Keniston , Roland McGrath , Ananth N Mavinakayanahalli , LKML In-Reply-To: <20110607125835.28590.25476.sendpatchset@localhost6.localdomain6> References: <20110607125804.28590.92092.sendpatchset@localhost6.localdomain6> <20110607125835.28590.25476.sendpatchset@localhost6.localdomain6> Content-Type: text/plain; charset="UTF-8" Date: Fri, 10 Jun 2011 01:03:27 +0200 Message-ID: <1307660607.2497.1771.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-06-07 at 18:28 +0530, Srikar Dronamraju wrote: > + ret = anon_vma_prepare(vma); > + if (ret) > + goto unlock_out; You just leaked new_page. > + > + lock_page(new_page); > + ret = __replace_page(vma, old_page, new_page); > + unlock_page(new_page); > + if (ret != 0) > + page_cache_release(new_page); > +unlock_out: > + unlock_page(old_page); > + > +put_out: > + put_page(old_page); /* we did a get_page in the beginning */ > + return ret; > +} From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id EEF5190011A for ; Thu, 9 Jun 2011 18:59:57 -0400 (EDT) Received: from j77219.upc-j.chello.nl ([24.132.77.219] helo=dyad.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.76 #1 (Red Hat Linux)) id 1QUoCh-00069l-Vr for linux-mm@kvack.org; Thu, 09 Jun 2011 22:59:56 +0000 Subject: Re: [PATCH v4 3.0-rc2-tip 2/22] 2: uprobes: Breakground page replacement. From: Peter Zijlstra In-Reply-To: <20110607125835.28590.25476.sendpatchset@localhost6.localdomain6> References: <20110607125804.28590.92092.sendpatchset@localhost6.localdomain6> <20110607125835.28590.25476.sendpatchset@localhost6.localdomain6> Content-Type: text/plain; charset="UTF-8" Date: Fri, 10 Jun 2011 01:03:27 +0200 Message-ID: <1307660607.2497.1771.camel@laptop> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Srikar Dronamraju Cc: Ingo Molnar , Steven Rostedt , Linux-mm , Arnaldo Carvalho de Melo , Linus Torvalds , Masami Hiramatsu , Hugh Dickins , Christoph Hellwig , Andi Kleen , Thomas Gleixner , Jonathan Corbet , Oleg Nesterov , Andrew Morton , Jim Keniston , Roland McGrath , Ananth N Mavinakayanahalli , LKML On Tue, 2011-06-07 at 18:28 +0530, Srikar Dronamraju wrote: > + ret = anon_vma_prepare(vma); > + if (ret) > + goto unlock_out; You just leaked new_page. > + > + lock_page(new_page); > + ret = __replace_page(vma, old_page, new_page); > + unlock_page(new_page); > + if (ret != 0) > + page_cache_release(new_page); > +unlock_out: > + unlock_page(old_page); > + > +put_out: > + put_page(old_page); /* we did a get_page in the beginning */ > + return ret; > +} -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org